Minor already existing error in the explanation string:
int mir_surface_event_get_attribute_value(MirSurfaceEvent const* event)
MIR_FOR_REMOVAL_IN_VERSION_1("use make_event with mir_window_event_get_attribute_value instead");
should be
int mir_surface_event_get_attribute_value(MirSurfaceEvent const* event)
MIR_FOR_REMOVAL_IN_VERSION_1("use mir_window_event_get_attribute_value with MirWindowEvent instead");
Minor already existing error in the explanation string:
int mir_surface_ event_get_ attribute_ value(MirSurfac eEvent const* event) REMOVAL_ IN_VERSION_ 1("use make_event with mir_window_ event_get_ attribute_ value instead");
MIR_FOR_
should be
int mir_surface_ event_get_ attribute_ value(MirSurfac eEvent const* event) REMOVAL_ IN_VERSION_ 1("use mir_window_ event_get_ attribute_ value with MirWindowEvent instead");
MIR_FOR_
or something like that.
Lgtm otherwise