Code review comment for lp:~alan-griffiths/mir/demo_server-fatal-errors-core-dump

Revision history for this message
Chris Halse Rogers (raof) wrote :

On 4 May 2016 6:54:42 PM AEST, Alan Griffiths <email address hidden> wrote:
>> Don't mind this; having Mir trigger apport on exceptions that reach
>> server::run()¹ would be a way of getting crash reports without taking
>down the
>> host process.
>> ¹: https://wiki.ubuntu.com/Apport/DeveloperHowTo
>Two questions:
>1. That link seems to be a lot of information about customizing apport,
>but gives little about the options for triggering it. It seems we need
>to write a small python script and execute that. I assume that can be
>coded to grab a stack trace?
>2. Is server::run() the right place? Threads have been joined and the
>stack has unwound by then. Surely we should be capturing information in
>the fatal_error() handler?
>You are reviewing the proposed merge of
>lp:~alan-griffiths/mir/demo_server-fatal-errors-core-dump into lp:mir.

We don't really *want* to be capturing a core, surely; we know where the exception is thrown from, and the exception *should* have more useful information than a core. The call stack is generally uninteresting for these things.

We'd just need to write a little Python script and pump roughly the output of boost_describe_exception into it...

« Back to merge proposal