Code review comment for lp:~alan-griffiths/mir/bump-mir-server-ABI

    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/4858/console
...
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4858/console

Hmm, did artful just switch toolchain?

13:38:01 11: ==10353== Use of uninitialised value of size 8
13:38:01 11: ==10353== at 0x50DED94: std::_Hashtable<mir::shell::PersistentSurfaceStore::Id, std::pair<mir::shell::PersistentSurfaceStore::Id const, std::weak_ptr<mir::scene::Surface> >, std::allocator<std::pair<mir::shell::PersistentSurfaceStore::Id const, std::weak_ptr<mir::scene::Surface> > >, std::__detail::_Select1st, std::equal_to<mir::shell::PersistentSurfaceStore::Id>, std::hash<mir::shell::PersistentSurfaceStore::Id>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_find_before_node(unsigned long, mir::shell::PersistentSurfaceStore::Id const&, unsigned long) const (hashtable.h:1413)
13:38:01 11: ==10353== by 0x50DDFBF: std::_Hashtable<mir::shell::PersistentSurfaceStore::Id, std::pair<mir::shell::PersistentSurfaceStore::Id const, std::weak_ptr<mir::scene::Surface> >, std::allocator<std::pair<mir::shell::PersistentSurfaceStore::Id const, std::weak_ptr<mir::scene::Surface> > >, std::__detail::_Select1st, std::equal_to<mir::shell::PersistentSurfaceStore::Id>, std::hash<mir::shell::PersistentSurfaceStore::Id>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_find_node(unsigned long, mir::shell::PersistentSurfaceStore::Id const&, unsigned long) const (hashtable.h:634)
13:38:01 11: ==10353== by 0x50DDD77: std::pair<std::__detail::_Node_iterator<std::pair<mir::shell::PersistentSurfaceStore::Id const, std::weak_ptr<mir::scene::Surface> >, false, true>, bool> std::_Hashtable<mir::shell::PersistentSurfaceStore::Id, std::pair<mir::shell::PersistentSurfaceStore::Id const, std::weak_ptr<mir::scene::Surface> >, std::allocator<std::pair<mir::shell::PersistentSurfaceStore::Id const, std::weak_ptr<mir::scene::Surface> > >, std::__detail::_Select1st, std::equal_to<mir::shell::PersistentSurfaceStore::Id>, std::hash<mir::shell::PersistentSurfaceStore::Id>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_emplace<std::pair<mir::shell::PersistentSurfaceStore::Id, std::shared_ptr<mir::scene::Surface> > >(std::integral_constant<bool, true>, std::pair<mir::shell::PersistentSurfaceStore::Id, std::shared_ptr<mir::scene::Surface> >&&) (hashtable.h:1527)
13:38:01 11: ==10353== by 0x50DD1DA: std::pair<std::__detail::_Node_iterator<std::pair<mir::shell::PersistentSurfaceStore::Id const, std::weak_ptr<mir::scene::Surface> >, false, true>, bool> std::__detail::_Insert<mir::shell::PersistentSurfaceStore::Id, std::pair<mir::shell::PersistentSurfaceStore::Id const, std::weak_ptr<mir::scene::Surface> >, std::allocator<std::pair<mir::shell::PersistentSurfaceStore::Id const, std::weak_ptr<mir::scene::Surface> > >, std::__detail::_Select1st, std::equal_to<mir::shell::PersistentSurfaceStore::Id>, std::hash<mir::shell::PersistentSurfaceStore::Id>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true>, false, true>::insert<std::pair<mir::shell::PersistentSurfaceStore::Id, std::shared_ptr<mir::scene::Surface> >, void>(std::pair<mir::shell::PersistentSurfaceStore::Id, std::shared_ptr<mir::scene::Surface> >&&) (hashtable_policy.h:901)
13:38:01 11: ==10353== by 0x50DC94F: std::pair<std::__detail::_Node_iterator<std::pair<mir::shell::PersistentSurfaceStore::Id const, std::weak_ptr<mir::scene::Surface> >, false, true>, bool> std::unordered_map<mir::shell::PersistentSurfaceStore::Id, std::weak_ptr<mir::scene::Surface>, std::hash<mir::shell::PersistentSurfaceStore::Id>, std::equal_to<mir::shell::PersistentSurfaceStore::Id>, std::allocator<std::pair<mir::shell::PersistentSurfaceStore::Id const, std::weak_ptr<mir::scene::Surface> > > >::insert<std::pair<mir::shell::PersistentSurfaceStore::Id, std::shared_ptr<mir::scene::Surface> >, void>(std::pair<mir::shell::PersistentSurfaceStore::Id, std::shared_ptr<mir::scene::Surface> >&&) (unordered_map.h:557)
13:38:01 11: ==10353== by 0x50DC293: mir::shell::DefaultPersistentSurfaceStore::SurfaceIdBimap::insert_or_retrieve(std::shared_ptr<mir::scene::Surface> const&) (default_persistent_surface_store.cpp:54)