Mir

Merge lp:~alan-griffiths/mir/add-missing-link-library into lp:mir

Proposed by Alan Griffiths
Status: Merged
Approved by: Cemil Azizoglu
Approved revision: no longer in the source branch.
Merged at revision: 4125
Proposed branch: lp:~alan-griffiths/mir/add-missing-link-library
Merge into: lp:mir
Diff against target: 11 lines (+1/-0)
1 file modified
src/platforms/android/utils/CMakeLists.txt (+1/-0)
To merge this branch: bzr merge lp:~alan-griffiths/mir/add-missing-link-library
Reviewer Review Type Date Requested Status
Cemil Azizoglu (community) Approve
Mir CI Bot continuous-integration Approve
Review via email: mp+321276@code.launchpad.net

Commit message

Add missing link library for mir_demo_standalone_render_overlays (LP: #1677239)

Description of the change

Add missing link library for mir_demo_standalone_render_overlays

Avoid accidentally linking against the system installed library (which isn't guaranteed to work). Vis:

//usr/lib/x86_64-linux-gnu/libmirclient.so.9: undefined reference to `MirInputDeviceStateEvent::device_pressed_keys_for_index(unsigned long, unsigned long) const@MIR_COMMON_0.25_PRIVATE'
//usr/lib/x86_64-linux-gnu/libmirclient.so.9: undefined reference to `MirPointerEvent::set_x(float)@MIR_COMMON_0.25_PRIVATE'
//usr/lib/x86_64-linux-gnu/libmirclient.so.9: undefined reference to `MirTouchEvent::pressure(unsigned long) const@MIR_COMMON_0.25_PRIVATE'

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:4125
https://mir-jenkins.ubuntu.com/job/mir-ci/3280/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/4422
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/4514
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/4504
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/4504
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/4504
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4454
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4454/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/4454
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/4454/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4454
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4454/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/4454
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/4454/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/4454
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/4454/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/4454
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/4454/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/3280/rebuild

review: Approve (continuous-integration)
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Ok

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/platforms/android/utils/CMakeLists.txt'
2--- src/platforms/android/utils/CMakeLists.txt 2017-01-18 02:29:37 +0000
3+++ src/platforms/android/utils/CMakeLists.txt 2017-03-29 11:40:30 +0000
4@@ -36,6 +36,7 @@
5 )
6
7 target_link_libraries(mir_demo_standalone_render_overlays
8+ mirclient
9 mircommon
10 mirplatform
11 )

Subscribers

People subscribed via source and target branches