Mir

Merge lp:~alan-griffiths/mir/Wno-non-virtual-dtor into lp:~hikiko/mir/mir.fix-missing-virtual-destructors

  1. Wno-non-virtual-dtor
  2. Merge into mir.fix-missing-virtual-de...
Proposed by Alan Griffiths
Status: Merged
Approved by: Eleni Maria Stea
Approved revision: no longer in the source branch.
Merge reported by: Eleni Maria Stea
Merged at revision: not available
Proposed branch: lp:~alan-griffiths/mir/Wno-non-virtual-dtor
Merge into: lp:~hikiko/mir/mir.fix-missing-virtual-destructors
Diff against target: 12 lines (+1/-1)
1 file modified
CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~alan-griffiths/mir/Wno-non-virtual-dtor
Reviewer Review Type Date Requested Status
Eleni Maria Stea Approve
Review via email: mp+165551@code.launchpad.net

Commit message

Get compiler to do the work

Description of the change

Get compiler to do the work

To post a comment you must log in.
Revision history for this message
Eleni Maria Stea (hikiko) wrote :

thank you! :D

review: Approve
Revision history for this message
Kevin DuBois (kdub) wrote :

I think jenkins doesn't pick up branch->branch merges, just branch->trunk merges.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2013-05-16 16:53:01 +0000
3+++ CMakeLists.txt 2013-05-24 09:10:33 +0000
4@@ -42,7 +42,7 @@
5 include (cmake/PrePush.cmake)
6
7 set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -g -Werror -Wall -pedantic -Wextra -fPIC")
8-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -std=c++0x -Werror -Wall -fno-strict-aliasing -pedantic -Wextra -fPIC")
9+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -std=c++0x -Werror -Wall -fno-strict-aliasing -pedantic -Wnon-virtual-dtor -Wextra -fPIC")
10 set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,--no-undefined")
11
12 #####################################################################

Subscribers

People subscribed via source and target branches