Merge lp:~alan-griffiths/mir/InputDeviceInfo-is-a-struct into lp:mir

[Alan Griffiths]

Use struct consistently for InputDeviceInfo in public headers.

Use struct consistently for InputDeviceInfo in public headers.

include/platform/mir/input/input_device_info.h uses "struct"
include/test/mir_test_framework/stub_server_platform_factory.h used "class"

We know that struct and class are interchangeable but clang doesn't and downstreams use it. So let's be polite and not cause them problems.

[Mir CI Bot (mir-ci-bot)]

PASSED: Continuous integration, rev:4135
https://mir-jenkins.ubuntu.com/job/mir-ci/3291/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/4447
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/4561
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/4551
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/4551
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/4551
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/4551
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4479
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4479/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/4479
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/4479/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4479
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4479/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/4479
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/4479/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/4479
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/4479/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/4479
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/4479/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/3291/rebuild

review: Approve (continuous-integration)

[Brandon Schaefer (brandontschaefer)]

lgtm, didnt know clang treated them differently. Though I agree, should make it correct for downstream.

review: Approve

=== modified file 'include/test/mir_test_framework/stub_server_platform_factory.h'
--- include/test/mir_test_framework/stub_server_platform_factory.h	2016-08-23 03:56:40 +0000
+++ include/test/mir_test_framework/stub_server_platform_factory.h	2017-04-03 15:50:07 +0000
@@ -31,7 +31,7 @@
 {
 namespace input
 {
-class InputDeviceInfo;
+struct InputDeviceInfo;
 }
 }