lp:~alan-griffiths/compiz-core/bug.936487

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz-core at revision 3018

Sam Spilsbury: Approve on 2012-02-23

Diff: 21 lines (+7/-4)

1 file modified

src/screen.cpp (+7/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #936487: compiz crashed with SIGSEGV in XDefineCursor()

High

Fix Released

Link a bug report

Related blueprints

3018. By Alan Griffiths on 2012-02-23

Fix for bug 936487

3017. By Sam Spilsbury on 2012-02-23

Check if the mutter key exists before using it. This fixes the lack of
draggable borders if mutter isn't installed. (LP: #936781)

3016. By Daniel van Vugt on 2012-02-22

Fix keyboard lockup, which occurred when a plugin was devious enough to
override handleEvent and not allow keyboard events to reach core.
(LP: #934058)

Arguably we should fix the offending plugin (unityshell). But I figured it's
better to make core more robust so that the same bug can never occur with
any plugin in future.

3015. By Daniel van Vugt on 2012-02-22

Remove dead code (extern declarations of non-existent globals).

3014. By Alan Griffiths on 2012-02-22

Delete dead code.

3013. By Sam Spilsbury on 2012-02-20

Fix typo which would cause maximized windows to not receive shadows at all

3012. By Sam Spilsbury on 2012-02-20

Also update state, actions and icon whenever the window becomes redecorated
as those may have changed while the window was undecorated

Merge lp:~smspillaz/compiz-core/compiz-core.fix_936778 into lp:compiz-core

3011. By Sam Spilsbury on 2012-02-20

  Don't silently let windows that we couldn't find a sibling below for sit
  at the top of the stack (LP #936675)

  If we couldn't find a sibling for the window upon initial map, then it means
  that it needs to be placed at the bottom of the stack, since there could be
  windows above it which should not be below the newly created window.

  Fixes a case where on startup, nautilus could be slow to load and new windows
  would be created before nautilus was, and those would go above panels incorrectly.

Merge lp:~smspillaz/compiz-core/compiz-core.fix_936675 into lp:compiz-core

3010. By Sam Spilsbury on 2012-02-20

Only call removeAction on the CompOption destructor and not the CompOption::Value
destructor, since plugins that make copies of CompOption::Value can cause actions to
be added through setOptionForPlugin and then those actions will be removed when the
value temporary goes away.

The action adding and removing only happens within the bounds of CompOption anyways, so
its its more appropriate to have it in its destructor.

Of course, this brings up another issue, which is that CompOption should be noncopyable
but this opens up a whole another can of worms.

How this even worked before is beyond me...

Merge lp:~smspillaz/compiz-core/compiz-core.fix_931927 into lp:compiz-core

3009. By Sam Spilsbury on 2012-02-20

Fixes the state atoms never being unset if no bits were being set.
This fixes the previous commit, which was a fix for LP: #932087.