Merge lp:~al-maisan/bzr-builddeb/pristine-tar into lp:~bzr-builddeb-hackers/bzr-builddeb/trunk-old
Proposed by
Muharem Hrnjadovic
Status: | Merged |
---|---|
Merged at revision: | not available |
Proposed branch: | lp:~al-maisan/bzr-builddeb/pristine-tar |
Merge into: | lp:~bzr-builddeb-hackers/bzr-builddeb/trunk-old |
Diff against target: | None lines |
To merge this branch: | bzr merge lp:~al-maisan/bzr-builddeb/pristine-tar |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Westby | Approve | ||
Review via email:
|
To post a comment you must log in.
Hello there!
This branch fixes the following kind of failure (bug #417153):
{{{ 2.0.0~bzr396/ .bzrignore: Cannot stat: No such file or directory tar.NQspZVOeeE/ recreatetarball --owner 0 --group 0 --numeric-owner -C /tmp/pristine- tar.NQspZVOeeE/ workdir --no-recursion --mode 0644 --files-from /tmp/pristine- tar.NQspZVOeeE/ manifest
$ bzr branch lp:ubuntu/gwibber; cd gwibber; bzr bd -S
Branched 11 revision(s).
Building using working tree
Looking for a way to retrieve the upstream tarball
Using pristine-tar to reconstruct the needed tarball.
tar: gwibber-
tar: Exiting with failure status due to previous errors
pristine-tar: command failed: tar cf /tmp/pristine-
bzr: ERROR: There was an error using pristine-tar: Generating tar from delta failed: None.
}}}
The "pristine-tar gentar" failure is now detected and an appropriate exception NotPresent) is raised to the caller so it can try to obtain the
(PackageVersion
required upstream tar ball from the next package source.
There are also two small "drive-by" fixes:
- format string fix in MissingChangelo gError
- removal of some "dead code" in import_dsc.py
NB: this is only the first part of the "pristine-tar" problem solution. A
forthcoming branch will make sure that the "pristine-tar gendelta" command
does not produce deltas with files missing from the unpacked source tree
(thus "obscuring" future "pristine-tar gentar" problems).
Please have a look and let me know what you think.