Merge lp:~akshayshah/postorius/postorius into lp:postorius

Proposed by akshay
Status: Needs review
Proposed branch: lp:~akshayshah/postorius/postorius
Merge into: lp:postorius
Diff against target: 52 lines (+11/-9)
1 file modified
src/postorius/templates/postorius/user_profile.html (+11/-9)
To merge this branch: bzr merge lp:~akshayshah/postorius/postorius
Reviewer Review Type Date Requested Status
Terri Needs Fixing
Review via email: mp+254232@code.launchpad.net

Description of the change

added editable profile page

To post a comment you must log in.
Revision history for this message
Terri (terriko) wrote :

This would make things editable, but I don't want to merge this patch unless the data is actually stored.

Short term recommended fix: set this up so it only has editable fields the data stored in Mailman Core, and that it saves that information, just like the other settings pages. This might mean that the only editable thing on the profile page will be "Display name" for now. (Keep the user name even if it's not editable, though)

review: Needs Fixing

Unmerged revisions

206. By akshay

user editable fields in profile

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/postorius/templates/postorius/user_profile.html'
2--- src/postorius/templates/postorius/user_profile.html 2014-10-15 20:59:52 +0000
3+++ src/postorius/templates/postorius/user_profile.html 2015-03-26 11:57:14 +0000
4@@ -5,37 +5,39 @@
5 {% block main %}
6 {% include 'postorius/menu/user_nav.html' %}
7 <h1>{% trans "User Profile" %} <span>- {{ user }}</span></h1>
8-
9+ <form action='/postorius/lists/' method='get'>
10 <table class="table table-bordered table-striped mm_userData">
11 <tbody>
12 <tr>
13- <td>{% trans 'Mailman display name' %}</td>
14- <td>{{ mm_user.display_name}}</td>
15+ <td>{% trans 'Mailman display name' %}</td>
16+ <td><input type='text' name='mailmanDisp' value="{{ mm_user.display_name}}"></input></td>
17 </tr>
18 <tr>
19 <td>{% trans 'User name' %}</td>
20- <td>{{ user.username}}</td>
21+ <td><input type='text' name='username' value="{{ user.username}}"></input></td>
22 </tr>
23 <tr>
24 <th>{% trans 'First name' %}</th>
25- <td>&nbsp;</td>
26+ <td><input type='text' name='firstname' /></td>
27 </tr>
28 <tr>
29 <th>{% trans 'Last name' %}</th>
30- <td>&nbsp;</td>
31+ <td><input type='text' name='lastname' /></td>
32 </tr>
33 <tr>
34 <th>{% trans 'IRC handle' %}</th>
35- <td>&nbsp;</td>
36+ <td><input type='text' name='irchandle' /></td>
37 </tr>
38 <tr>
39 <th>{% trans 'Website' %}</th>
40- <td>&nbsp;</td>
41+ <td><input type='text' name='website' /></td>
42 </tr>
43 <tr>
44 <th>{% trans 'Twitter' %}</th>
45- <td>&nbsp;</td>
46+ <td><input type='text' name='twitter' /></td>
47 </tr>
48 </tbody>
49 </table>
50+ <input type='submit' value='Save' />
51+ </form>
52 {% endblock main %}

Subscribers

People subscribed via source and target branches