Merge lp:~akretion-team/server-env-tools/server-env-tools into lp:~server-env-tools-core-editors/server-env-tools/7.0

[Sébastien BEAU - http://www.akretion.com]

Here is a proposal too add new fields for image and binary. There is a example module so you can try it. But before merging I propose to remove it.

Here is teh refactor of product image based on it https://code.launchpad.net/~akretion-team/openerp-product-attributes/openerp-product-attributes-product-image

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

I left some comments in the diff.
As discussed, it would be nice to be able to pass a configuration dict or function for the storage in the declaration of the fields.

review: Needs Fixing (code review)

[lp:~akretion-team/server-env-tools/server-env-tools]

13. By Sébastien BEAU - http://www.akretion.com on 2014-06-06

[FIX] fix typo, missing context and use interger for file size

14. By Sébastien BEAU - http://www.akretion.com on 2014-06-06

[IMP] add the params config so you can pass some special config to your Storage Class

15. By Sébastien BEAU - http://www.akretion.com on 2014-06-06

[IMP] Update example module

[Georges Racinet (gracinet)]

Hi Sébastien,
could you be a bit more specific in the branch description, what's the intended scope/purpose, that kind of thing ? Maybe as a short, committed doc file ?

Am I right to believe that you did a new field parly to avoid the base64 roundtrips ?

Maybe I overlooked it, but the controllers need serious work too (current OpenERP 7 impl is feeble to say the least.

BTW, I'm interested because of the Postgres Large Object support we published on Bitbucket (https://bitbucket.org/anybox/advanced_attachment/src/37ba6c51432bb106b30c500a00b89ff91c9e5ccc/attachment_large_object/?at=default)

Thanks !

[lp:~akretion-team/server-env-tools/server-env-tools]

16. By Sébastien BEAU - http://www.akretion.com on 2014-06-08

[REF] remove useless option filters as this option have been drop with the gtk client

17. By Sébastien BEAU - http://www.akretion.com on 2014-06-08

[IMP] update description and add doc string

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

Hi Georges,

Sorry I fix the description.
In my case I want to store every binary/image field on the file system and not in postgresql. And this not only for attachement but for every image/binary field (image field on product, on category....) I want this because I want to serve my image directly with nginx without using Postgresql, OpenERP.

You storage on Large Object seem really interesting and as I can pass a custom storage class to my field maybe we can create a new custom class for storing in Large Object and reuse you work.

I add a doc string and update the description, give me your feedback

Thanks

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

Hi
I am asking myself about adding an object "storage.configuration" and a field "storing_configuration_id" on the model "ir.model.fields". The idea will to use a default storing configuration for every field (on file sytem for exemple) but after we will be able to customise on every field from the backend where where you want to store each binary/image fields (database, S3, ftp, SFTP, Filestore....)
Do you like the idea? (not so hard to implement)

[Lorenzo Battistini (elbati)]

Hello Sébastien,
some PEP8 improvements here
https://code.launchpad.net/~agilebg/server-env-tools/binary_field_pep8/+merge/223935

[Lorenzo Battistini (elbati)]

"I am asking myself about adding an object "storage.configuration" and a field "storing_configuration_id" on the model "ir.model.fields". The idea will to use a default storing configuration for every field (on file sytem for exemple) but after we will be able to customise on every field from the backend where where you want to store each binary/image fields (database, S3, ftp, SFTP, Filestore....)
Do you like the idea?"

I like it :-)

[lp:~akretion-team/server-env-tools/server-env-tools]

18. By Sébastien BEAU - http://www.akretion.com on 2014-06-22

[MERGE] merge pep 8 clean up done by Lorenzo Battistini - Agile BG, thanks

19. By Sébastien BEAU - http://www.akretion.com on 2014-07-01

[REF] refcactor code, merge the class ImageFieldResize into the class ImageField

20. By Sébastien BEAU - http://www.akretion.com on 2014-07-01

[REF] refactor storage, add a new object "storage.configuration" that allow user to customise the storage configuration per field. Also base the image file storage on odoo V8 code

21. By Sébastien BEAU - http://www.akretion.com on 2014-07-01

[FIX] fix delete methode

22. By Sébastien BEAU - http://www.akretion.com on 2014-07-01

[FIX] Fix init method, original method should be call at the end

23. By Sébastien BEAU - http://www.akretion.com on 2014-07-01

[FIX] default storage should be in no update state

24. By Sébastien BEAU - http://www.akretion.com on 2014-07-04

[FIX] remove useless added file by error

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

Hi I have finish the storage refactor, so please give me your feedback !
Also I have move this MP on github so let's comment here => https://github.com/OCA/server-tools/pull/1

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

review: Needs Resubmitting (pr created on github)

[Hans Yonathan (hans-yonathan)]

Hi Sebastien,

I tried to use your module, for image field is working fine.
For BinaryField, we can upload, and it can save to our filestore, the problem is when we want to download the file, we cannot open the file anymore.
can you take a look?
I tried your example module, and the behaviour is the same.

review: Needs Fixing

Unmerged revisions

24. By Sébastien BEAU - http://www.akretion.com on 2014-07-04

[FIX] remove useless added file by error

23. By Sébastien BEAU - http://www.akretion.com on 2014-07-01

[FIX] default storage should be in no update state

22. By Sébastien BEAU - http://www.akretion.com on 2014-07-01

[FIX] Fix init method, original method should be call at the end

21. By Sébastien BEAU - http://www.akretion.com on 2014-07-01

[FIX] fix delete methode

20. By Sébastien BEAU - http://www.akretion.com on 2014-07-01

[REF] refactor storage, add a new object "storage.configuration" that allow user to customise the storage configuration per field. Also base the image file storage on odoo V8 code

19. By Sébastien BEAU - http://www.akretion.com on 2014-07-01

[REF] refcactor code, merge the class ImageFieldResize into the class ImageField

18. By Sébastien BEAU - http://www.akretion.com on 2014-06-22

[MERGE] merge pep 8 clean up done by Lorenzo Battistini - Agile BG, thanks

17. By Sébastien BEAU - http://www.akretion.com on 2014-06-08

[IMP] update description and add doc string

16. By Sébastien BEAU - http://www.akretion.com on 2014-06-08

[REF] remove useless option filters as this option have been drop with the gtk client

15. By Sébastien BEAU - http://www.akretion.com on 2014-06-06

[IMP] Update example module

=== added directory 'binary_field'
=== added file 'binary_field/__init__.py'
--- binary_field/__init__.py	1970-01-01 00:00:00 +0000
+++ binary_field/__init__.py	2014-07-04 09:58:26 +0000
@@ -0,0 +1,25 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#
+#   Module for OpenERP
+#   Copyright (C) 2013 Akretion (http://www.akretion.com).
+#   @author Sébastien BEAU <[e-mail]>
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+
+from . import fields
+from . import storage
+from . import ir_model

=== added file 'binary_field/__openerp__.py'
--- binary_field/__openerp__.py	1970-01-01 00:00:00 +0000
+++ binary_field/__openerp__.py	2014-07-04 09:58:26 +0000
@@ -0,0 +1,80 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#
+#   Module for OpenERP
+#   Copyright (C) 2013 Akretion (http://www.akretion.com).
+#   @author Sébastien BEAU <[e-mail]>
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+
+{'name': 'Binary Field',
+ 'version': '0.0.1',
+ 'author': 'Akretion',
+ 'website': 'www.akretion.com',
+ 'license': 'AGPL-3',
+ 'category': 'Framework',
+ 'description': """This module extend the fields class in order to add 3 new
+type of fields.
+- BinaryStore
+- ImageStore
+- ImageRezise
+
+All of this fields will be store on the file system by default and not in the
+database. If you want to store it on an other support (database, S3, ftp,
+SFTP...)
+Then you should create your own 'storage class' and use your custom 'storage
+class' instead
+
+The default Storage class will store the field on the file system and build
+the path like that
+
+ BASE_LOCATION/DB_NAME/MODEL-FIELD/XXX/YYYYY
+
+with
+
+- BASE_LOCATION: the base location configured in ir.config_parameter
+- DB_NAME:  your database name
+- MODEL-FIELD: the concatenation of the name of the model with the name of the
+field, for example 'product_product-image'
+- XXX: the first 3 letter of the file name build with their sha1 hash
+- YYYYYY: file name build with their sha1 hash
+
+Here is an example of field declaration
+
+    'binary_test': fields.BinaryField('Test Binary'),
+    'image_test': fields.ImageField('Test Image',
+        config={
+            'field_key': 'StoreMeHere',
+            'base_location': 'file:///testpath',
+            }),
+    'image_test_resize': fields.ImageResizeField(
+        related_field='image_test',
+        string='Test Image small',
+        height=64,
+        width=64,
+        ),
+ """,
+ 'depends': [
+     'base',
+ ],
+ 'data': [
+     'data.xml',
+     'ir_model_view.xml',
+     'storage_view.xml',
+ ],
+ 'installable': True,
+ 'application': True,
+}

=== added file 'binary_field/data.xml'
--- binary_field/data.xml	1970-01-01 00:00:00 +0000
+++ binary_field/data.xml	2014-07-04 09:58:26 +0000
@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<openerp>
+    <data noupdate="1">
+        <record id="default_filesystem_storage" model="storage.configuration">
+            <field name="type">filesystem</field>
+            <field name="name">Default File System Storage</field>
+            <field name="base_path">openerp/filestore/</field>
+            <field name="is_default">1</field>
+        </record>
+    </data>
+</openerp>

=== added file 'binary_field/fields.py'
--- binary_field/fields.py	1970-01-01 00:00:00 +0000
+++ binary_field/fields.py	2014-07-04 09:58:26 +0000
@@ -0,0 +1,311 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#
+#   Module for OpenERP
+#   Copyright (C) 2014 Akretion (http://www.akretion.com).
+#   @author Sébastien BEAU <[e-mail]>
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+
+import hashlib
+from openerp.osv import fields, orm
+from openerp.tools import image_resize_image
+from openerp.tools.translate import _
+from openerp import tools
+import os
+import sys
+import logging
+
+_logger = logging.getLogger(__name__)
+
+
+class Storage(object):
+
+    def __init__(self, cr, uid, model_name, field_name, record, config):
+        self.cr = cr
+        self.uid = uid
+        self.pool = record._model.pool
+        self.field_name = field_name
+        self.model_name = model_name
+        self.config = config
+
+
+class FileSystemStorage(Storage):
+
+    def _full_path(self, cr, uid, fname):
+        return os.path.join(
+            self.config['base_path'],
+            self.cr.dbname,
+            '%s-%s' % (self.model_name, self.field_name),
+            fname)
+
+    # Code extracted from Odoo V8 in ir_attachment.py
+    # Copyright (C) 2004-2014 OPENERP SA
+    # Licence AGPL V3
+    def _get_path(self, cr, uid, bin_data):
+        sha = hashlib.sha1(bin_data).hexdigest()
+        # scatter files across 256 dirs
+        # we use '/' in the db (even on windows)
+        fname = sha[:2] + '/' + sha
+        full_path = self._full_path(cr, uid, fname)
+        dirname = os.path.dirname(full_path)
+        if not os.path.isdir(dirname):
+            os.makedirs(dirname)
+        return fname, full_path
+
+    def _file_read(self, cr, uid, fname, bin_size=False):
+        full_path = self._full_path(cr, uid, fname)
+        r = ''
+        try:
+            if bin_size:
+                r = os.path.getsize(full_path)
+            else:
+                r = open(full_path,'rb').read().encode('base64')
+        except IOError:
+            _logger.error("_read_file reading %s",full_path)
+        return r
+
+    def _file_write(self, cr, uid, value):
+        bin_value = value.decode('base64')
+        fname, full_path = self._get_path(cr, uid, bin_value)
+        if not os.path.exists(full_path):
+            try:
+                with open(full_path, 'wb') as fp:
+                    fp.write(bin_value)
+            except IOError:
+                _logger.error("_file_write writing %s", full_path)
+        return fname
+
+    def _file_delete(self, cr, uid, fname):
+        obj = self.pool[self.model_name]
+        count = obj.search(cr, 1, [
+            ('%s_uid' % self.field_name, '=', fname),
+            ], count=True)
+        full_path = self._full_path(cr, uid, fname)
+        if count <= 1 and os.path.exists(full_path):
+            try:
+                os.unlink(full_path)
+            except OSError:
+                _logger.error("_file_delete could not unlink %s",full_path)
+            except IOError:
+                # Harmless and needed for race conditions
+                _logger.error("_file_delete could not unlink %s",full_path)
+    # END of extraction
+
+    def add(self, value):
+        if not value:
+            return {}
+        file_size = sys.getsizeof(value.decode('base64'))
+        _logger.debug('Add binary to model: %s, field: %s'
+                      % (self.model_name, self.field_name))
+        binary_uid = self._file_write(self.cr, self.uid, value)       
+        return {
+            'binary_uid': binary_uid,
+            'file_size': file_size,
+            }
+
+    def update(self, binary_uid, value):
+        _logger.debug('Delete binary model: %s, field: %s, uid: %s'
+                      % (self.model_name, self.field_name, binary_uid))
+        self._file_delete(self.cr, self.uid, binary_uid)
+        if not value:
+            return {}
+        return self.add(value)
+
+    def get(self, binary_uid):
+        return self._file_read(self.cr, self.uid, binary_uid)
+
+
+class BinaryField(fields.function):
+
+    def __init__(self, string, **kwargs):
+        """Init a BinaryField field
+        :params string: Name of the field
+        :type string: str
+        :params get_storage: Storage Class for processing the field
+                            by default use the Storage on filesystem
+        :type get_storage: :py:class`binary_field.Storage'
+        :params config: configuration used by the storage class
+        :type config: what you want it's depend of the Storage class
+                      implementation
+        """
+        new_kwargs = {
+            'type': 'binary',
+            'string': string,
+            'fnct_inv': self._fnct_write,
+            'multi': False,
+            }
+        new_kwargs.update(kwargs)
+        super(BinaryField, self).__init__(self._fnct_read, **new_kwargs)
+
+    # No postprocess are needed
+    # we already take care of bin_size option in the context
+    def postprocess(self, cr, uid, obj, field, value=None, context=None):
+        return value
+
+    def _prepare_binary_meta(self, cr, uid, field_name, res, context=None):
+        return {
+            '%s_uid' % field_name: res.get('binary_uid'),
+            '%s_file_size' % field_name: res.get('file_size'),
+            }
+
+    def _fnct_write(self, obj, cr, uid, ids, field_name, value, args,
+                    context=None):
+        if not isinstance(ids, (list, tuple)):
+            ids = [ids]
+        storage_obj = obj.pool['storage.configuration']
+        for record in obj.browse(cr, uid, ids, context=context):
+            storage = storage_obj.get_storage(cr, uid, field_name, record)
+            binary_uid = record['%s_uid' % field_name]
+            if binary_uid:
+                res = storage.update(binary_uid, value)
+            else:
+                res = storage.add(value)
+            vals = self._prepare_binary_meta(
+                cr, uid, field_name, res, context=context)
+            record.write(vals)
+        return True
+
+    def _fnct_read(self, obj, cr, uid, ids, field_name, args, context=None):
+        result = {}
+        storage_obj = obj.pool['storage.configuration']
+        for record in obj.browse(cr, uid, ids, context=context):
+            storage = storage_obj.get_storage(cr, uid, field_name, record)
+            binary_uid = record['%s_uid' % field_name]
+            if binary_uid:
+                # Compatibility with existing binary field
+                if context.get(
+                    'bin_size_%s' % field_name, context.get('bin_size')
+                ):
+                    size = record['%s_file_size' % field_name]
+                    result[record.id] = tools.human_size(long(size))
+                else:
+                    result[record.id] = storage.get(binary_uid)
+            else:
+                result[record.id] = None
+        return result
+
+
+class ImageField(BinaryField):
+
+    def __init__(self, string, get_storage=Storage, config=None, 
+            resize_based_on=None, height=64, width=64, **kwargs):
+        """Init a ImageField field
+        :params string: Name of the field
+        :type string: str
+        :params get_storage: Storage Class for processing the field
+                            by default use the Storage on filesystem
+        :type get_storage: :py:class`binary_field.Storage'
+        :params config: configuration used by the storage class
+        :type config: what you want it's depend of the Storage class
+                      implementation
+        :params resize_based_on: reference field that should be resized
+        :type resize_based_on: str
+        :params height: height of the image resized
+        :type height: integer
+        :params width: width of the image resized
+        :type width: integer
+        """
+        super(ImageField, self).__init__(
+            string,
+            get_storage=get_storage,
+            config=config,
+            **kwargs)
+        self.resize_based_on = resize_based_on
+        self.height = height
+        self.width = width
+
+    def _fnct_write(self, obj, cr, uid, ids, field_name, value, args,
+                    context=None):
+        if context is None:
+            context = {}
+        related_field_name = obj._columns[field_name].resize_based_on
+
+        # If we write an original image in a field with the option resized
+        # We have to store the image on the related field and not on the
+        # resized image field
+        if related_field_name and not context.get('refresh_image_cache'):
+            return self._fnct_write(
+                obj, cr, uid, ids, related_field_name, value, args,
+                context=context)
+        else:
+            super(ImageField, self)._fnct_write(
+                obj, cr, uid, ids, field_name, value, args, context=context)
+            
+            for name, field in obj._columns.items():
+                if isinstance(field, ImageField)\
+                   and field.resize_based_on == field_name:
+                    field._refresh_cache(
+                        obj, cr, uid, ids, name, context=context)
+        return True
+
+    def _refresh_cache(self, obj, cr, uid, ids, field_name, context=None):
+        """Refresh the cache of the small image
+        :params ids: list of object id to refresh
+        :type ids: list
+        :params field_name: Name of the field to refresh the cache
+        :type field_name: str
+        """
+        if context is None:
+            context = {}
+        if not isinstance(ids, (list, tuple)):
+            ids = [ids]
+        for record_id in ids:
+            _logger.debug('Refreshing Image Cache from the field %s of object '
+                          '%s id : %s' % (field_name, obj._name, record_id))
+            field = obj._columns[field_name]
+            record = obj.browse(cr, uid, record_id, context=context)
+            original_image = record[field.resize_based_on]
+            if original_image:
+                size = (field.height, field.width)
+                resized_image = image_resize_image(original_image, size)
+            else:
+                resized_image = None
+            ctx = context.copy()
+            ctx['refresh_image_cache'] = True
+            self._fnct_write(obj, cr, uid, [record_id], field_name,
+                             resized_image, None, context=ctx)
+
+
+fields.BinaryField = BinaryField
+fields.ImageField = ImageField
+
+
+original__init__ = orm.BaseModel.__init__
+
+
+def __init__(self, pool, cr):
+    if pool.get('binary.field.installed'):
+        additional_field = {}
+        for field_name in self._columns:
+            field = self._columns[field_name]
+            if isinstance(field, BinaryField):
+                additional_field.update({
+                    '%s_uid' % field_name:
+                        fields.char('%s UID' % self._columns[field_name].string),
+                    '%s_file_size' % field_name:
+                        fields.integer(
+                            '%s File Size' % self._columns[field_name].string),
+                    })
+        self._columns.update(additional_field)
+    original__init__(self, pool, cr)
+
+
+orm.BaseModel.__init__ = __init__
+
+
+class BinaryFieldInstalled(orm.AbstractModel):
+    _name = 'binary.field.installed'

=== added file 'binary_field/ir_model.py'
--- binary_field/ir_model.py	1970-01-01 00:00:00 +0000
+++ binary_field/ir_model.py	2014-07-04 09:58:26 +0000
@@ -0,0 +1,35 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#
+#   Module for OpenERP
+#   Copyright (C) 2014 Akretion (http://www.akretion.com).
+#   @author Sébastien BEAU <[e-mail]>
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+
+from openerp.osv import fields, orm
+
+class IrModelFields(orm.Model):
+    _inherit = 'ir.model.fields'
+    
+    _columns = {
+        'storage_id': fields.many2one(
+            'storage.configuration',
+            'Custom Storage',
+            help=("Select a custom storage configuration. "
+                  "If the field is empty the default one will be use")
+            ),
+        }

=== added file 'binary_field/ir_model_view.xml'
--- binary_field/ir_model_view.xml	1970-01-01 00:00:00 +0000
+++ binary_field/ir_model_view.xml	2014-07-04 09:58:26 +0000
@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<openerp>
+    <data>
+
+        <record id="view_model_form" model="ir.ui.view">
+            <field name="model">ir.model</field>
+            <field name="inherit_id" ref="base.view_model_form" />
+            <field name="arch" type="xml">
+                <field name="on_delete" position="after">
+                    <field name="storage_id"/>
+                </field>
+            </field>
+        </record>
+
+        <record id="view_model_fields_form" model="ir.ui.view">
+            <field name="model">ir.model.fields</field>
+            <field name="inherit_id" ref="base.view_model_fields_form" />
+            <field name="arch" type="xml">
+                <field name="on_delete" position="after">
+                    <field name="storage_id"/>
+                </field>
+            </field>
+        </record>
+
+    </data>
+</openerp>

=== added file 'binary_field/storage.py'
--- binary_field/storage.py	1970-01-01 00:00:00 +0000
+++ binary_field/storage.py	2014-07-04 09:58:26 +0000
@@ -0,0 +1,117 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#
+#   Module for OpenERP
+#   Copyright (C) 2014 Akretion (http://www.akretion.com).
+#   @author Sébastien BEAU <[e-mail]>
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+
+from .fields import FileSystemStorage
+from openerp.osv import fields, orm
+
+
+class StorageConfiguration(orm.Model):
+    _name = 'storage.configuration'
+    _description = 'storage configuration'
+   
+    def _get_storage_map_class(self, cr, uid, context=None):
+        return {
+            'filesystem' : FileSystemStorage,
+            }
+
+    def _get_class(self, cr, uid, type, context=None):
+        map_class = self._get_storage_map_class(cr, uid, context=context)
+        return map_class[type]
+
+    def _get_config(self, cr, uid, model_name, field_name, context=None):
+        field_obj = self.pool['ir.model.fields']
+        field_id = field_obj.search(cr, uid, [
+            ('model', '=', model_name),
+            ('name', '=', field_name),
+            ], context=context)
+        if not field_id:
+            raise orm.except_orm(
+                _('Dev Error'),
+                _('The field %s with do not exist on the model %s')
+                %(field, model))
+        else:
+            field_id = field_id[0]
+        field = field_obj.browse(cr, uid, field_id, context=context)
+        storage_id = field.storage_id.id
+        if not storage_id:
+            storage_id = self.search(cr, uid, [
+                ('is_default', '=', True),
+                ], context=context)
+            if storage_id:
+                storage_id = storage_id[0]
+            else:
+                raise orm.except_orm(
+                    _('User Error'),
+                    _('There is not default storage configuration, '
+                      'please add one'))
+        return self.read(cr, uid, storage_id, self._columns.keys(),
+                         context=context)
+
+    def get_storage(self, cr, uid, field_name, record, context=None):
+        model_name = record._name
+        config = self._get_config(cr, uid, record._name, field_name)
+        storage_class = self._get_class(
+            cr, uid, config['type'], context=context)
+        return storage_class(cr, uid, model_name, field_name, record, config)
+
+    def _get_storage_type(self, cr, uid, context=None):
+        return [('filesystem', 'File System')]
+
+    def __get_storage_type(self, cr, uid, context=None):
+        return self._get_storage_type(cr, uid, context=context)
+
+    def _remove_default(self, cr, uid, context=None):
+        conf_id = self.search(cr, uid, [
+            ('is_default', '=', True),
+            ], context=context)
+        self.write(cr, uid, conf_id, {
+            'is_default': False,
+            }, context=context)
+
+    def create(self, cr, uid, vals, context=None):
+        if context is None:
+            context = {}
+        if vals.get('is_default'):
+            self._remove_default(cr, uid, context=context)
+        return super(StorageConfiguration, self).\
+            create(cr, uid, vals, context=context)
+    
+    def write(self, cr, uid, ids, vals, context=None):
+        if context is None:
+            context = {}
+        if vals.get('is_default'):
+            self._remove_default(cr, uid, context=context)
+        return super(StorageConfiguration, self).\
+            write(cr, uid, ids, vals, context=context)
+
+    _columns = {
+        'name': fields.char('Name'),
+        'type': fields.selection(
+            __get_storage_type,
+            'Type',
+            help='Type of storage'),
+        'base_path': fields.char('Path'),
+        'is_default': fields.boolean(
+            'Is default',
+            help=('Tic that box in order to select '
+                 'the default storage configuration')),
+    }

=== added file 'binary_field/storage_view.xml'
--- binary_field/storage_view.xml	1970-01-01 00:00:00 +0000
+++ binary_field/storage_view.xml	2014-07-04 09:58:26 +0000
@@ -0,0 +1,65 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<openerp>
+    <data>
+        <record id="view_storage_configuration_tree" model="ir.ui.view">
+            <field name="model">storage.configuration</field>
+            <field name="arch" type="xml">
+                <tree string="Storage Configuration">
+                    <field name="name"/>
+                    <field name="type"/>
+                </tree>
+            </field>
+        </record>
+        
+        <record id="view_storage_configuration_form" model="ir.ui.view">
+            <field name="model">storage.configuration</field>
+            <field name="arch" type="xml">
+                <form string="Storage Configuration">
+                    <field name="name"/>
+                    <field name="type"/>
+                    <field name="base_path"/>
+                </form>
+            </field>
+        </record>
+        
+        <record id="view_storage_configuration_search" model="ir.ui.view">
+            <field name="model">storage.configuration</field>
+            <field name="arch" type="xml">
+                <search string="Storage Configuration">
+                    <field name="name"/>
+                </search>
+            </field>
+        </record>
+        
+        <record model="ir.actions.act_window" id="act_open_storage_configuration_view">
+            <field name="name">Storage Configuration</field>
+            <field name="type">ir.actions.act_window</field>
+            <field name="res_model">storage.configuration</field>
+            <field name="view_type">form</field>
+            <field name="view_mode">tree,form</field>
+            <field name="search_view_id" ref="view_storage_configuration_search"/>
+            <field name="domain">[]</field>
+            <field name="context">{}</field>
+        </record>
+        
+        <record model="ir.actions.act_window.view" id="act_open_storage_configuration_view_form">
+            <field name="act_window_id" ref="act_open_storage_configuration_view"/>
+            <field name="sequence" eval="20"/>
+            <field name="view_mode">form</field>
+            <field name="view_id" ref="view_storage_configuration_form"/>
+        </record>
+        
+        <record model="ir.actions.act_window.view" id="act_open_storage_configuration_view_tree">
+            <field name="act_window_id" ref="act_open_storage_configuration_view"/>
+            <field name="sequence" eval="10"/>
+            <field name="view_mode">tree</field>
+            <field name="view_id" ref="view_storage_configuration_tree"/>
+        </record>
+        
+        <menuitem id="menu_storage_configuration"
+            parent="base.next_id_9"
+            sequence="20"
+            action="act_open_storage_configuration_view"/>
+
+    </data>
+</openerp>

=== added directory 'binary_field_example'
=== added file 'binary_field_example/__init__.py'
--- binary_field_example/__init__.py	1970-01-01 00:00:00 +0000
+++ binary_field_example/__init__.py	2014-07-04 09:58:26 +0000
@@ -0,0 +1,24 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#
+#   Module for OpenERP 
+#   Copyright (C) 2013 Akretion (http://www.akretion.com).
+#   @author Sébastien BEAU <[e-mail]>
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+
+from . import res_company
+

=== added file 'binary_field_example/__openerp__.py'
--- binary_field_example/__openerp__.py	1970-01-01 00:00:00 +0000
+++ binary_field_example/__openerp__.py	2014-07-04 09:58:26 +0000
@@ -0,0 +1,44 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#
+#   Module for OpenERP 
+#   Copyright (C) 2013 Akretion (http://www.akretion.com).
+#   @author Sébastien BEAU <[e-mail]>
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+
+{'name': 'binary field example',
+ 'version': '0.0.1',
+ 'author': 'Akretion',
+ 'website': 'www.akretion.com',
+ 'license': 'AGPL-3',
+ 'category': 'Generic Modules',
+ 'description': """Just an example
+ 
+ """,
+ 'depends': [
+     'binary_field',
+ ],
+ 'data': [
+     'res_company_view.xml',
+ ],
+ 'installable': True,
+ 'application': True,
+}
+
+
+
+

=== added file 'binary_field_example/res_company.py'
--- binary_field_example/res_company.py	1970-01-01 00:00:00 +0000
+++ binary_field_example/res_company.py	2014-07-04 09:58:26 +0000
@@ -0,0 +1,38 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#
+#   Module for OpenERP 
+#   Copyright (C) 2013 Akretion (http://www.akretion.com).
+#   @author Sébastien BEAU <[e-mail]>
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+
+from openerp.osv import fields, orm
+
+
+class ResCompany(orm.Model):
+    _inherit = 'res.company'
+    
+    _columns = {
+        'binary_test': fields.BinaryField('Test Binary'),
+        'image_test': fields.ImageField('Test Image'),
+        'image_test_resize': fields.ImageField(
+            'Test Image small',
+            resize_based_on='image_test',
+            height=64,
+            width=64,
+            ),
+    }

=== added file 'binary_field_example/res_company_view.xml'
--- binary_field_example/res_company_view.xml	1970-01-01 00:00:00 +0000
+++ binary_field_example/res_company_view.xml	2014-07-04 09:58:26 +0000
@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<openerp>
+    <data>
+
+        <record id="view_res_company_form" model="ir.ui.view">
+            <field name="model">res.company</field>
+            <field name="inherit_id" ref="base.view_company_form"/>
+            <field name="arch" type="xml">
+                <field name="parent_id" position="after">
+                    <field name="binary_test"/>
+                    <field name="image_test" widget='image'/>
+                    <field name="image_test_resize" widget='image'/>
+                </field>
+            </field>
+        </record>
+
+    </data>
+</openerp>