Merge lp:~akretion-team/partner-contact-management/7.0-partner-helper-dbl into lp:~partner-contact-core-editors/partner-contact-management/7.0

[David BEAL (ak)]

Add specific methods to deal with address

On this commit get_split_address()

to deal with 2 streets fields in Odoo/openerp and X streets fields for data exchange : carrier, logistic, etc.

[lp:~akretion-team/partner-contact-management/7.0-partner-helper-dbl]

3. By David BEAL (ak) on 2014-05-30

[FIX] change method name to match convention

[Pedro Manuel Baeza (pedro.baeza)]

Hi, David,

I see this a very light functionality to include it as "partner general tools" or partner helper. You don't even document in what helps on module description, so for me, I don't see suitable to include on the repository, but I'm going to mark my review to Abstain to let others judge.

Regards.

review: Abstain (code review)

[lp:~akretion-team/partner-contact-management/7.0-partner-helper-dbl]

4. By David BEAL (ak) on 2014-06-16

[IMP] add comments on __openerp__.py

[David BEAL (ak) (davidbeal)]

Hi Pedro,

Thank you for your review. You're right, feature is small and module name is a little large.
But it avoid to grow up excessively the number of module in Odoo for small features.

Thanks to the community to review and suggest to add other useful methods

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

As it's a small abstract feature, I think it make sense to create a helper module for all similary one. The aim is just to have one module which is a toolbox with all abstract feature (not user feature) that can be use everythere.
Description is clear now so I approve

review: Approve (test, review)

[Pedro Manuel Baeza (pedro.baeza)]

OK, let's use this module as is as an umbrella for future partner related functionality.

One last thing: please rename to base_partner_helper to match current convention on naming (Odoo is talking even to create a base_partner split from base module).

Regards.

review: Needs Fixing (code review)

[lp:~akretion-team/partner-contact-management/7.0-partner-helper-dbl]

5. By David BEAL (ak) on 2014-06-19

[FIX] change module name to base partner_helper

[David BEAL (ak) (davidbeal)]

Hi Pedro

module is renamed and ready for merge

Thank you

Regards

[Pedro Manuel Baeza (pedro.baeza)]

Great, thanks.

Regards.

review: Approve (code review)

[David BEAL (ak) (davidbeal)]

Hi Pedro,

It seems this module can be merged in this branch, 2 approves now.

Could you proceed it.

Launchpad is yet the master for this repo. Not for a long time.

Thank you

Regards

[Pedro Manuel Baeza (pedro.baeza)]

Done.

=== added directory 'base_partner_helper'
=== added file 'base_partner_helper/__init__.py'
--- base_partner_helper/__init__.py	1970-01-01 00:00:00 +0000
+++ base_partner_helper/__init__.py	2014-06-19 09:40:29 +0000
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author: Sébastien BEAU <[e-mail]>
+#    Copyright 2014 Akretion
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from . import partner   # noqa

=== added file 'base_partner_helper/__openerp__.py'
--- base_partner_helper/__openerp__.py	1970-01-01 00:00:00 +0000
+++ base_partner_helper/__openerp__.py	2014-06-19 09:40:29 +0000
@@ -0,0 +1,64 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author: Sébastien BEAU <[e-mail]>
+#    Copyright 2014 Akretion
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    'name': 'Partner Helper',
+    'version': '0.1',
+    'author': 'Akretion',
+    'maintainer': 'Akretion',
+    'category': 'Warehouse',
+    'depends': [
+        'base',
+    ],
+    'description': """
+Partner Helper
+==============
+The purpose of this module is to gather generic partner methods in the same module.
+It avoid to grow up excessively the number of module in Odoo for small features.
+
+Description
+-----------
+Add specific helper methods to deal with partners:
+
+* _get_split_address():
+    This method allows to get a number of street fields according to
+    your choice. 2 fields by default in Odoo with 128 width chars.
+    In some countries you have constraints on width of street fields and you
+    should use 3 or 4 shorter fields.
+    You also need of this feature to avoid headache with overflow printing task
+
+* other_method():
+
+Contributors
+------------
+* Sébastien BEAU <[e-mail]>
+* David BEAL <[e-mail]>
+
+
+    """,
+    'website': 'http://www.akretion.com/',
+    'data': [],
+    'tests': [],
+    'installable': True,
+    'auto_install': False,
+    'license': 'AGPL-3',
+    'application': False,
+}

=== added file 'base_partner_helper/partner.py'
--- base_partner_helper/partner.py	1970-01-01 00:00:00 +0000
+++ base_partner_helper/partner.py	2014-06-19 09:40:29 +0000
@@ -0,0 +1,67 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author: Sébastien BEAU <[e-mail]>
+#    Copyright 2014 Akretion
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import orm
+
+
+def split_char(char, output_number, size):
+    words = char.split(' ')
+    result = []
+    word = words.pop(0)
+    for index in range(0, output_number):
+        result.append(word)
+        word = ''
+        while len(words) > 0:
+            word = words.pop(0)
+            if len(result[index] + ' %s' % word) > size:
+                break
+            else:
+                result[index] += ' %s' % word
+                word = ''
+    return result
+
+
+class ResPartner(orm.Model):
+    _inherit = "res.partner"
+
+    def _get_split_address(
+            self, cr, uid, partner, output_number, max_size, context=None):
+        """ This method allows to get a number of street fields according to
+            your choice. Default is 2 large fields in Odoo (128 chars).
+            In some countries you may use 3 or 4 shorter street fields.
+
+            example:
+            res = self.pool['res.partner']._get_split_address(
+                cr, uid, picking.partner_id, 3, 35, context=context)
+            address['street'], address['street2'], address['street3'] = res
+        """
+        street = partner.street or ''
+        street2 = partner.street2 or ''
+        if len(street) <= max_size and len(street2) <= max_size:
+            result = ['' for i in range(0, output_number)]
+            result[0] = street
+            result[1] = street2
+            return result
+        elif street <= max_size:
+            return [street] + split_char(street2, output_number - 1, max_size)
+        else:
+            return split_char('%s %s' % (street, street2), output_number, max_size)
+