Merge lp:~akretion-team/openobject-server/openobject-server-fix-ir_model-field_description into lp:openobject-server/7.0

[David BEAL (ak)]

Avoid to crash when you change 'field_description' value with some non ascii 128 chars

[FIX] replace 'str' by 'unicode' in 'ir_model_fields' class (write method) in 'model_props' list for 'field_description' field

How to reproduce the bug
see https://bugs.launchpad.net/openobject-server/+bug/1231900

[David BEAL (ak) (davidbeal)]

my IDE delete spaces in the end of lines like in lines 17, 26, 35

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

I confirm both the bug and the fact this is a valid fix for it (tested here). Thanks for merging.

review: Approve

Unmerged revisions

5089. By David BEAL (ak) on 2013-09-27

[FIX] replace 'str' by 'unicode' in 'ir_model_fields' class (write method) in 'model_props' list for 'field_description' field : avoid to crash when you change 'field_description' value with some non ascii chars

=== modified file 'openerp/addons/base/ir/ir_model.py'
--- openerp/addons/base/ir/ir_model.py	2013-07-30 11:46:45 +0000
+++ openerp/addons/base/ir/ir_model.py	2013-09-27 10:04:00 +0000
@@ -381,7 +381,7 @@
 
         # static table of properties
         model_props = [ # (our-name, fields.prop, set_fn)
-            ('field_description', 'string', str),
+            ('field_description', 'string', unicode),
             ('required', 'required', bool),
             ('readonly', 'readonly', bool),
             ('domain', '_domain', eval),
@@ -504,7 +504,7 @@
     def _module_data_uninstall(self, cr, uid, ids, context=None):
         """
         Delete PostgreSQL foreign keys and constraints tracked by this model.
-        """ 
+        """
 
         if uid != SUPERUSER_ID and not self.pool.get('ir.model.access').check_groups(cr, uid, "base.group_system"):
             raise except_orm(_('Permission Denied'), (_('Administrator access is required to uninstall a module')))
@@ -565,7 +565,7 @@
     def _module_data_uninstall(self, cr, uid, ids, context=None):
         """
         Delete PostgreSQL many2many relations tracked by this model.
-        """ 
+        """
 
         if uid != SUPERUSER_ID and not self.pool.get('ir.model.access').check_groups(cr, uid, "base.group_system"):
             raise except_orm(_('Permission Denied'), (_('Administrator access is required to uninstall a module')))
@@ -1020,11 +1020,11 @@
         ``ids`` along with their corresponding database backed (including
         dropping tables, columns, FKs, etc, as long as there is no other
         ir.model.data entry holding a reference to them (which indicates that
-        they are still owned by another module). 
+        they are still owned by another module).
         Attempts to perform the deletion in an appropriate order to maximize
         the chance of gracefully deleting all records.
         This step is performed as part of the full uninstallation of a module.
-        """ 
+        """
 
         ids = self.search(cr, uid, [('module', 'in', modules_to_remove)])