Merge lp:~akretion-team/openobject-addons/trunk-simple-user-to-employee into lp:openobject-addons

[Alexis de Lattre]

In OpenERP 6.0, there was an "address_id" field on res_users, which provided a link from res_users to res_partner_address. This field was usefull to print the phone numbers of the salesman on quotes and invoices for example ; the "Salesman" field on res.partner, sale.order and account.invoice points to res_users, so we could use "o.user_id.address_id.phone" to display the fixed phone number of the Salesman for example.

This address_id field was removed of the "base" module in OpenERP server trunk in revision 3526 (August 2011) cf http://bazaar.launchpad.net/~openerp/openobject-server/trunk/revision/3526. The source commit in the dev branch is this one : http://bazaar.launchpad.net/~openerp-dev/openobject-server/trunk-usability-remove_address_id_email-rmu/revision/3425

So, we are not able to access detailed user information (phone numbers, etc...) from the res_users object any more.
After some thoughts, I think that the best solution is to add a link from res_users to hr_employee.
This merge proposal :
- Adds an 'employee_ids' one2many field on res.users ; it is the reverse of the 'user_id' many2one field on hr.employee.
- Add the field to the form view of res.users.

This merge proposal is a much simpler alternative to my other merge proposal https://code.launchpad.net/~alexis-via/openobject-addons/trunk-user-to-employee/+merge/90075. In fact, it doesn't add any complexity because it just defines the reverse one2many link of an existing many2one link between hr.employee and res.users.

I hope that this very simple merge proposal will be accepted in trunk.

Unmerged revisions

6460. By Alexis de Lattre on 2012-02-14

[Merge] with latest addons-trunk.

6459. By Alexis de Lattre on 2012-02-13

Add 'employee_ids' one2many field on res.users ; it is the reverse of the 'user_id' many2one field on hr.employee.
Add the field to the form view of res.users.

=== modified file 'hr/hr.py'
--- hr/hr.py	2012-01-31 13:36:57 +0000
+++ hr/hr.py	2012-02-14 09:12:22 +0000
@@ -274,6 +274,11 @@
 
         return user_id
 
+    _columns = {
+        'employee_ids': fields.one2many('hr.employee', 'user_id', 'Related employees',
+            help="List of employees that are attached to this user"),
+        }
+
 res_users()
 
 

=== modified file 'hr/hr_department_view.xml'
--- hr/hr_department_view.xml	2011-12-19 16:54:40 +0000
+++ hr/hr_department_view.xml	2012-02-14 09:12:22 +0000
@@ -63,9 +63,16 @@
             <field name="model">res.users</field>
             <field name="inherit_id" ref="base.view_users_form"/>
             <field name="arch" type="xml">
-                <group name="default_filters" position="inside">
-                    <field name="context_department_id" completion="1" widget="selection" string="Department"/>
-                </group>
+                <data>
+                    <group name="default_filters" position="inside">
+                        <field name="context_department_id" completion="1" widget="selection" string="Department"/>
+                    </group>
+                    <page string="Access Rights" position="after">
+                        <page string="Employees">
+                            <field name="employee_ids" nolabel="1" colspan="4" />
+                        </page>
+                    </page>
+                </data>
             </field>
         </record>
         <record model="ir.ui.view" id="view_department_form_simple_modif_inherited1">
@@ -79,5 +86,5 @@
                 </group>
             </field>
         </record>
-        </data>
+    </data>
 </openerp>