Code review comment for lp:~akretion-team/openobject-addons/trunk-extensible-sale-action-invoice-create

Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Hello,

It looks good to me, the only few things we will change while merging are the following:

- restore _inv_get() method for compatibility (to be removed after 6.1 for example)
- add missing context guard in _prepare_invoice (our convention is that all methods that access the context should care for the None case, even if they are currently always called with a context)
- some docstrings improvements to follow our current docstring conventions (but I understand that you copied an existing one ;-))

Thanks for the clean refactoring!

review: Approve

« Back to merge proposal