Merge lp:~akretion-team/openobject-addons/trunk-addons-fix-price_get_multi into lp:openobject-addons

[Alexis de Lattre]

This is a copy-paste of my explaination on the bug report https://bugs.launchpad.net/openobject-addons/+bug/1175983 :

In product/pricelist.py, if you enter the function price_get_multi() with context['date'] = False or None, you will have an error message :
<<
At least one pricelist has no active version ! Please create or activate one.
>>

For example, one scenario where you enter the function function price_get_multi() with context['date'] = False or None is when you use the module "product_visible_discount" :

in product_visible_discount.py line 87, inside the function product_id_change() you have :

list_price = pricelist_obj.price_get(cr, uid, [pricelist], product.id, qty or 1.0, partner_id, {'uom': uom,'date': date_order })
(the function price_get() calls price_get_multi())

and the default value for the variable "date_order" is False, as you can see in the proto of the function product_id_change().

I think that the proper fix for this is simply to test if context['date'] has a value before using it for the 'date' variable in the function price_get_multi() in product/pricelist.py. My merge proposal implements this fix.

[Martin Trigaux (OpenERP) (mat-openerp)]

Hello,

We have already merged your fix into openerp 7.0 (revision 9470). The code will be forward ported to trunk soon and I will then reject this branch.

Thanks for the code and the report

Unmerged revisions

8697. By Alexis de Lattre on 2013-05-03

[FIX] Don't raise an error when context['date'] is False or None

=== modified file 'product/pricelist.py'
--- product/pricelist.py	2013-04-22 15:34:49 +0000
+++ product/pricelist.py	2013-05-03 10:42:28 +0000
@@ -150,7 +150,7 @@
             context = {}
 
         date = time.strftime('%Y-%m-%d')
-        if 'date' in context:
+        if 'date' in context and context['date']:
             date = context['date']
 
         currency_obj = self.pool.get('res.currency')