Merge lp:~akretion-team/openerp-product-variant/migr-v7-wip into lp:openerp-product-variant/trunk

[Raphaël Valyi - http://www.akretion.com]

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

v7.0 migration; work in progress

The XML part has been largely migrated and the dependency upon the stock module has finally been relaxed.

Sadly some strange infinite loops at the ORM level seems to occur so I disable the value_ids field in the product.template form view so far. Also adding some template dimension with a few option will also cause some infinite Python loop when saving...
The data model of the product variants is a bit complex, may be it's creating some kind of infinite recursion between the triggers of the several models involved, no idea yet. Feel free to help finish the migration or fix the OpenERP ORM bugs (there are likely).

[lp:~akretion-team/openerp-product-variant/migr-v7-wip]

196. By Raphaël Valyi - http://www.akretion.com on 2013-02-16

[MIGR][product_variant_multi] disabled order criteria that seems to lock the server on OpenERP 7.0, disabled stock module specific things that would break the variant generation (this should be cleaned up and may be a stock variant module may be created); enabled the value_ids field again as it works

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Hum much better now: we have nearly all the features working again!
I isolated what would lock the server (and the browser javascript engine!): it was an ordering condition to help keep numeric option ordered. I disabled that condition for now (may be something would need to be done to enable it again).
Also I disabled some stock specific things (though not 100% cleanly yet) that would break the variant generation without the stock module.
My view is that installing variants shouldn't harm OpenERP modularity: so if really needed some stock variant module should be built to generate the stock properties of the variants properly.
For now I suggest analysing a bit better which fields are only found on the stock module and cleaning them systematically from the code and the interface. This systematic cleanup is yet to be done.

[lp:~akretion-team/openerp-product-variant/migr-v7-wip]

197. By Alexis de Lattre on 2013-04-04

Continue porting to OpenERP v7
Some code clean-up and usability enhancements
Includes some of the changes proposed by agustin

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

I propose to accept Anybox's merge instead https://code.launchpad.net/~akretion-team/openerp-product-variant/migr-v7-wip/+merge/148852
at least they got more review and said they were using it in production. On my side, was only a prototype (not sure on yours Aflexis). It's just to bad we double worked on that one.

Eventually we can later analysis if there are more fixes from this commit http://bazaar.launchpad.net/~akretion-team/openerp-product-variant/migr-v7-wip/revision/197 to replay once Anybox's branch is merged.

review: Disapprove

=== modified file 'product_variant_multi/__init__.py'
--- product_variant_multi/__init__.py	2011-02-01 17:08:05 +0000
+++ product_variant_multi/__init__.py	2013-04-04 09:34:23 +0000
@@ -1,9 +1,9 @@
 # -*- encoding: utf-8 -*-
 ##############################################################################
 #
-#    OpenERP, Open Source Management Solution	
+#    OpenERP, Open Source Management Solution
 #    Copyright (C) 2004-2008 Tiny SPRL (<http://tiny.be>). All Rights Reserved
-#    $Id$
+#    Copyright (C) 2010-2013 Akretion (http://www.akretion.com)
 #
 #    This program is free software: you can redistribute it and/or modify
 #    it under the terms of the GNU General Public License as published by
@@ -22,5 +22,3 @@
 
 import product_variant
 
-# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
-

=== modified file 'product_variant_multi/__openerp__.py'
--- product_variant_multi/__openerp__.py	2012-02-14 04:15:54 +0000
+++ product_variant_multi/__openerp__.py	2013-04-04 09:34:23 +0000
@@ -1,9 +1,9 @@
 # -*- encoding: utf-8 -*-
 ##############################################################################
 #
-#    OpenERP, Open Source Management Solution	
+#    OpenERP, Open Source Management Solution
 #    Copyright (C) 2004-2008 Tiny SPRL (<http://tiny.be>). All Rights Reserved
-#    $Id$
+#    Copyright (C) 2010-2013 Akretion (http://www.akretion.com)
 #
 #    This program is free software: you can redistribute it and/or modify
 #    it under the terms of the GNU General Public License as published by
@@ -20,10 +20,12 @@
 #
 ##############################################################################
 {
-    "name" : "Products with multi-level variants",
+    "name" : "Product Variant Multi",
     "version" : "1.0",
-    "author" : "Tiny, Akretion",
-    "category" : "Generic Modules/Inventory Control",
+    "author" : "OpenERP SA, Akretion",
+    "category" : "Sales Management",
+    "license": "AGPL-3",
+    "summary": "Products with multi-dimension variants",
     "description":"""
 Multi-axial varianted product support for OpenERP
 =================================================
@@ -57,19 +59,15 @@
 transparent as OpenERP modules try to get their properties like name from product.product
 and only from product.template if not found on product.product. But at least you
 will have been warned.
-
-The dependence to the stock module is weak, it's only there to be able to put the
-variant menu in the warehouse management sub-menu (sigh!).
     """,
-    "depends" : ["product", "stock"],
-    "init_xml" : [],
-    "demo_xml" : ["demo_data.xml"],
-    "update_xml" : [
+    "depends" : ["product"],
+    "demo" : ["demo_data.xml"],
+    "data" : [
         "security/ir.model.access.csv",
         "product_view.xml",
     ],
+    "application": True,
     "active": False,
-    "installable": True
+    "installable": True,
 }
-# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
 

=== modified file 'product_variant_multi/product_variant.py'
--- product_variant_multi/product_variant.py	2012-10-16 11:52:59 +0000
+++ product_variant_multi/product_variant.py	2013-04-04 09:34:23 +0000
@@ -3,7 +3,7 @@
 #
 #    OpenERP, Open Source Management Solution
 #    Copyright (C) 2004-2008 Tiny SPRL (<http://tiny.be>). All Rights Reserved
-#    Copyright (C) 2010-2011 Akretion (www.akretion.com). All Rights Reserved
+#    Copyright (C) 2010-2013 Akretion (www.akretion.com). All Rights Reserved
 #    @author Sebatien Beau <[e-mail]>
 #    @author Raphaël Valyi <[e-mail]>
 #    @author Alexis de Lattre <[e-mail]>
@@ -24,11 +24,11 @@
 #
 ##############################################################################
 
-from osv import fields, osv
-import decimal_precision as dp
+from openerp.osv import fields, osv, orm
+import openerp.addons.decimal_precision as dp
 # Lib to eval python code with security
-from tools.safe_eval import safe_eval
-from tools.translate import _
+from openerp.tools.safe_eval import safe_eval
+from openerp.tools.translate import _
 
 import logging
 _logger = logging.getLogger(__name__)
@@ -36,22 +36,22 @@
 #
 # Dimensions Definition
 #
-class product_variant_dimension_type(osv.osv):
+class product_variant_dimension_type(osv.Model):
     _name = "product.variant.dimension.type"
     _description = "Dimension Type"
 
     _columns = {
         'description': fields.char('Description', size=64, translate=True),
-        'name' : fields.char('Dimension', size=64, required=True),
-        'sequence' : fields.integer('Sequence', help="The product 'variants' code will use this to order the dimension values"),
-        'option_ids' : fields.one2many('product.variant.dimension.option', 'dimension_id', 'Dimension Options'),
+        'name': fields.char('Dimension Type Name', size=64, required=True),
+        'sequence': fields.integer('Sequence', help="The product 'variants' code will use this to order the dimension values"),
+        'option_ids': fields.one2many('product.variant.dimension.option', 'dimension_id', 'Dimension Options'),
         'product_tmpl_id': fields.many2many('product.template', 'product_template_dimension_rel', 'dimension_id', 'template_id', 'Product Template'),
         'allow_custom_value': fields.boolean('Allow Custom Value', help="If true, custom values can be entered in the product configurator"),
         'mandatory_dimension': fields.boolean('Mandatory Dimension', help="If false, variant products will be created with and without this dimension"),
     }
 
     _defaults = {
-        'mandatory_dimension': lambda * a: 1,
+        'mandatory_dimension': 1,
     }
 
     _order = "sequence, name"
@@ -64,7 +64,7 @@
 product_variant_dimension_type()
 
 
-class product_variant_dimension_option(osv.osv):
+class product_variant_dimension_option(osv.Model):
     _name = "product.variant.dimension.option"
     _description = "Dimension Option"
 
@@ -72,18 +72,18 @@
         return self.pool.get('product.variant.dimension.value').search(cr, uid, [('dimension_id', 'in', ids)], context=context)
 
     _columns = {
-        'name' : fields.char('Name', size=64, required=True),
-        'code' : fields.char('Code', size=64),
-        'sequence' : fields.integer('Sequence'),
-        'dimension_id' : fields.many2one('product.variant.dimension.type', 'Dimension Type', ondelete='cascade'),
+        'name': fields.char('Dimension Option Name', size=64, required=True),
+        'code': fields.char('Code', size=64),
+        'sequence': fields.integer('Sequence'),
+        'dimension_id': fields.many2one('product.variant.dimension.type', 'Dimension Type', ondelete='cascade'),
     }
 
-    _order = "dimension_id, sequence, to_number(name, '')"
+    _order = "dimension_id, sequence, name"
 
 product_variant_dimension_option()
 
 
-class product_variant_dimension_value(osv.osv):
+class product_variant_dimension_value(osv.Model):
     _name = "product.variant.dimension.value"
     _description = "Dimension Value"
 
@@ -91,7 +91,7 @@
         for value in self.browse(cr, uid, ids, context=context):
             if value.product_ids:
                 product_list = '\n    - ' + '\n    - '.join([product.name for product in value.product_ids])
-                raise osv.except_osv(_('Dimension value can not be removed'), _("The value %s is used by the products : %s \n Please remove these products before removing the value." % (value.option_id.name, product_list)))
+                raise orm.except_orm(_('Dimension value can not be removed'), _("The value %s is used by the products : %s \n Please remove these products before removing the value." % (value.option_id.name, product_list)))
         return super(product_variant_dimension_value, self).unlink(cr, uid, ids, context)
 
     def _get_values_from_types(self, cr, uid, ids, context=None):
@@ -102,7 +102,7 @@
 
     _columns = {
         'option_id' : fields.many2one('product.variant.dimension.option', 'Option', required=True),
-        'name': fields.related('option_id', 'name', type='char', relation='product.variant.dimension.option', string="Dimension value", readonly=True),
+        'name': fields.related('option_id', 'name', type='char', relation='product.variant.dimension.option', string="Dimension Value", readonly=True),
         'sequence' : fields.integer('Sequence'),
         'price_extra' : fields.float('Sale Price Extra', digits_compute=dp.get_precision('Sale Price')),
         'price_margin' : fields.float('Sale Price Margin', digits_compute=dp.get_precision('Sale Price')),
@@ -117,11 +117,11 @@
                 'product.variant.dimension.type': (_get_values_from_types, ['sequence'], 10),
             }),
         'product_ids': fields.many2many('product.product', 'product_product_dimension_rel', 'dimension_id', 'product_id', 'Variant', readonly=True),
-        'active' : fields.boolean('Active?', help="If false, this value will be not use anymore for generating variant"),
+        'active' : fields.boolean('Active', help="If false, this value will not be used anymore to generate variants."),
     }
 
     _defaults = {
-        'active': lambda * a: 1,
+        'active': True,
     }
 
     _sql_constraints = [ ('opt_dim_tmpl_uniq', 'UNIQUE(option_id, dimension_id, product_tmpl_id)',
@@ -132,9 +132,11 @@
 product_variant_dimension_value()
 
 
-class product_template(osv.osv):
+class product_template(osv.Model):
     _inherit = "product.template"
 
+    _order = "name"
+
     _columns = {
         'name': fields.char('Name', size=128, translate=True, select=True),
         'dimension_type_ids':fields.many2many('product.variant.dimension.type', 'product_template_dimension_rel', 'template_id', 'dimension_id', 'Dimension Types'),
@@ -143,7 +145,7 @@
         'variant_model_name':fields.char('Variant Model Name', size=64, required=True, help='[_o.dimension_id.name_] will be replaced by the name of the dimension and [_o.option_id.code_] by the code of the option. Example of Variant Model Name : "[_o.dimension_id.name_] - [_o.option_id.code_]"'),
         'variant_model_name_separator':fields.char('Variant Model Name Separator', size=64, help='Add a separator between the elements of the variant name'),
         'code_generator' : fields.char('Code Generator', size=256, help='enter the model for the product code, all parameter between [_o.my_field_] will be replace by the product field. Example product_code model : prefix_[_o.variants_]_suffixe ==> result : prefix_2S2T_suffix'),
-        'is_multi_variants' : fields.boolean('Is Multi Variants?'),
+        'is_multi_variants' : fields.boolean('Is Multi Variants'),
         'variant_track_production' : fields.boolean('Track Production Lots on variants ?'),
         'variant_track_incoming' : fields.boolean('Track Incoming Lots on variants ?'),
         'variant_track_outgoing' : fields.boolean('Track Outgoing Lots on variants ?'),
@@ -152,9 +154,9 @@
     }
 
     _defaults = {
-        'variant_model_name': lambda * a: '[_o.dimension_id.name_] - [_o.option_id.name_]',
-        'variant_model_name_separator': lambda * a: ' - ',
-        'is_multi_variants' : lambda * a: False,
+        'variant_model_name': '[_o.dimension_id.name_] - [_o.option_id.name_]',
+        'variant_model_name_separator': ' - ',
+        'is_multi_variants' : False,
         'code_generator' : "[_'-'.join([x.option_id.name for x in o.dimension_value_ids] or ['CONF'])_]",
     }
 
@@ -291,7 +293,7 @@
 product_template()
 
 
-class product_product(osv.osv):
+class product_product(osv.Model):
     _inherit = "product.product"
 
     def init(self, cr):
@@ -352,15 +354,15 @@
             new_default_code = self.generate_product_code(cr, uid, product, product.product_tmpl_id.code_generator, context=context)
             current_values = {
                 'default_code': product.default_code,
-                'track_production': product.track_production,
-                'track_outgoing': product.track_outgoing,
-                'track_incoming': product.track_incoming,
+#                'track_production': product.track_production,
+#                'track_outgoing': product.track_outgoing,
+#                'track_incoming': product.track_incoming,
             }
             new_values = {
                 'default_code': new_default_code,
-                'track_production': product.product_tmpl_id.variant_track_production,
-                'track_outgoing': product.product_tmpl_id.variant_track_outgoing,
-                'track_incoming': product.product_tmpl_id.variant_track_incoming,
+#                'track_production': product.product_tmpl_id.variant_track_production,
+#                'track_outgoing': product.product_tmpl_id.variant_track_outgoing,
+#                'track_incoming': product.product_tmpl_id.variant_track_incoming,
             }
             if new_values != current_values:
                 self.write(cr, uid, [product.id], new_values, context=context)
@@ -407,7 +409,7 @@
                 buffer.append(value.dimension_id)
             unique_set = set(buffer)
             if len(unique_set) != len(buffer):
-                raise osv.except_osv(_('Constraint error :'), _("On product '%s', there are several dimension values for the same dimension type.") % product.name)
+                raise orm.except_orm(_('Constraint error :'), _("On product '%s', there are several dimension values for the same dimension type.") % product.name)
         return True
 
     def compute_product_dimension_extra_price(self, cr, uid, product_id, product_price_extra=False, dim_price_margin=False, dim_price_extra=False, context=None):
@@ -482,9 +484,9 @@
         #the way the weight are implemented are not clean at all, we should redesign the module product form the addons in order to get something correclty.
         #indeed some field of the template have to be overwrited like weight, name, weight_net, volume.
         #in order to have a consitent api we should use the same field for getting the weight, now we have to use "weight" or "total_weight" not clean at all with external syncronization
-        'total_weight': fields.function(_product_compute_weight_volume, method=True, type='float', string='Gross weight', help="The gross weight in Kg.", multi='weight_volume'),
-        'total_weight_net': fields.function(_product_compute_weight_volume, method=True, type='float', string='Net weight', help="The net weight in Kg.", multi='weight_volume'),
-        'total_volume':  fields.function(_product_compute_weight_volume, method=True, type='float', string='Volume', help="The volume in m3.", multi='weight_volume'),
+        'total_weight': fields.function(_product_compute_weight_volume, method=True, type='float', string='Total Gross Weight', help="The gross weight in Kg.", multi='weight_volume'),
+        'total_weight_net': fields.function(_product_compute_weight_volume, method=True, type='float', string='Total Net Weight', help="The net weight in Kg.", multi='weight_volume'),
+        'total_volume':  fields.function(_product_compute_weight_volume, method=True, type='float', string='Total Volume', help="The volume in m3.", multi='weight_volume'),
         'additional_weight': fields.float('Additional Gross weight', help="The additional gross weight in Kg."),
         'additional_weight_net': fields.float('Additional Net weight', help="The additional net weight in Kg."),
         'additional_volume': fields.float('Additional Volume', help="The additional volume in Kg."),

=== modified file 'product_variant_multi/product_view.xml'
--- product_variant_multi/product_view.xml	2012-10-16 14:22:32 +0000
+++ product_variant_multi/product_view.xml	2013-04-04 09:34:23 +0000
@@ -1,4 +1,4 @@
-<?xml version="1.0" ?>
+<?xml version="1.0" encoding="utf-8"?>
 <openerp>
     <data>
 
@@ -10,35 +10,27 @@
 -->
 
 
-        <record id="product_variant" model="ir.actions.act_window">
-            <field name="name">Product Variants</field>
-            <field name="res_model">product.product</field>
-            <field name="view_type">form</field>
-            <field name="view_mode">tree,form</field>
-        </record>
-
-        <record id="product_template" model="ir.actions.act_window">
-            <field name="name">Product Templates</field>
-            <field name="res_model">product.template</field>
-            <field name="view_type">form</field>
-            <field name="domain">[('is_multi_variants','=',True)]</field>
-            <field name="view_mode">tree,form</field>
-        </record>
-
-        <menuitem action="product_template" id="menu_template" parent="stock.menu_stock_product" />
-
-        <menuitem action="product_variant" id="menu_variant" parent="stock.menu_stock_product" />
-
-        <menuitem name="Variant dimensions" id="menu_variant_dimension" parent="stock.menu_product_in_config_stock" />
-
-        <!-- Views from Dimension option -->
+        <menuitem name="Variant Dimensions" id="menu_variant_dimension" parent="product.prod_config_main" />
+
+
+        <!-- DIMENSION OPTION -->
+        <record id="product_variant_multi_dimension_option_seach" model="ir.ui.view">
+            <field name="name">product.variant.multi.dimension.option.search</field>
+            <field name="model">product.variant.dimension.option</field>
+            <field name="arch" type="xml">
+                <search string="Dimension Options Search">
+                    <field name="name"/>
+                    <field name="dimension_id"/>
+                </search>
+            </field>
+        </record>
+
         <record id="product_variant_multi_dimension_option_tree" model="ir.ui.view">
             <field name="name">product.variant.multi.dimension.option.tree</field>
             <field name="model">product.variant.dimension.option</field>
-            <field name="type">tree</field>
             <field name="arch" type="xml">
-                <tree string="Dimension Options">
-                    <field name="dimension_id" invisible="not context.get('dimension_value_main_view', False)" />
+                <tree string="Dimension Options" editable="top">
+                    <field name="dimension_id" invisible="not context.get('dimension_option_main_view', False)" />
                     <field name="name" />
                     <field name="sequence" />
                     <field name="code" />
@@ -49,40 +41,47 @@
         <record id="product_variant_multi_dimension_option_form" model="ir.ui.view">
             <field name="name">product.variant.multi.dimension.option.form</field>
             <field name="model">product.variant.dimension.option</field>
-            <field name="type">form</field>
             <field name="arch" type="xml">
                 <form string="Dimension Options">
-                    <field name="dimension_id" select="1" invisible="not context.get('dimension_option_main_view', False)" />
+                    <field name="dimension_id" invisible="not context.get('dimension_option_main_view', False)" />
                     <newline />
                     <field name="sequence" />
-                    <field name="name" select="1" />
+                    <field name="name" />
                     <field name="code" />
                 </form>
             </field>
         </record>
 
-        <!-- Default action for Dimension option -->
-		<record id="action_dimension_option" model="ir.actions.act_window">
-			<field name="name">Dimension Options</field>
-			<field name="res_model">product.variant.dimension.option</field>
+        <record id="action_dimension_option" model="ir.actions.act_window">
+            <field name="name">Dimension Options</field>
+            <field name="res_model">product.variant.dimension.option</field>
             <field name="view_type">form</field>
-			<field name="view_mode">tree,form</field>
+            <field name="view_mode">tree,form</field>
             <field name="context">{'dimension_option_main_view': True}</field>
-		</record>
-
-        <!-- Menu entry for Dimension values -->
-		<menuitem id="menu_variant_dimension_option" icon="STOCK_JUSTIFY_FILL" parent="menu_variant_dimension" action="action_dimension_option" />
-
-
-
-        <!-- Views from Dimension values -->
+        </record>
+
+        <menuitem id="menu_variant_dimension_option" parent="menu_variant_dimension" action="action_dimension_option" />
+
+
+        <!-- DIMENSION VALUES -->
+        <record id="product_variant_multi_dimension_value_search" model="ir.ui.view">
+            <field name="name">product.variant.multi.dimension.value.search</field>
+            <field name="model">product.variant.dimension.value</field>
+            <field name="arch" type="xml">
+                <search string="Dimension Values Search">
+                    <field name="product_tmpl_id"/>
+                    <field name="option_id"/>
+                </search>
+            </field>
+        </record>
+
+
         <record id="product_variant_multi_dimension_value_tree" model="ir.ui.view">
             <field name="name">product.variant.multi.dimension.value.tree</field>
             <field name="model">product.variant.dimension.value</field>
-            <field name="type">tree</field>
             <field name="arch" type="xml">
-                <tree string="Dimension values" editable="top">
-                    <field name="product_tmpl_id" select="1" invisible="not context.get('dimension_value_main_view', False)" />
+                <tree string="Dimension Values" editable="top">
+                    <field name="product_tmpl_id" invisible="not context.get('dimension_value_main_view', False)" />
                     <field name="active" />
                     <field name="dimension_id" />
                     <field name="option_id" />
@@ -96,91 +95,98 @@
         <record id="product_variant_multi_dimension_value_form" model="ir.ui.view">
             <field name="name">product.variant.multi.dimension.value.form</field>
             <field name="model">product.variant.dimension.value</field>
-            <field name="type">form</field>
             <field name="arch" type="xml">
-                <form string="Dimension values">
-                    <field name="product_tmpl_id" select="1" invisible="not context.get('dimension_value_main_view', False)" />
+                <form string="Dimension Values">
+                    <field name="product_tmpl_id" invisible="not context.get('dimension_value_main_view', False)" />
                     <field name="active" />
                     <field name="dimension_id" />
                     <newline />
-                    <field name="option_id" select="1" />
+                    <field name="option_id" />
                     <field name="sequence" />
-                    <field name="cost_price_extra" select="2" />
-                    <field name="price_extra" select="2" />
-                    <field name="price_margin" select="2" />
+                    <field name="cost_price_extra" />
+                    <field name="price_extra" />
+                    <field name="price_margin" />
                 </form>
             </field>
         </record>
 
-        <!-- Default action for Dimension values -->
-		<record id="action_dimension_value" model="ir.actions.act_window">
-			<field name="name">Dimension values</field>
-			<field name="res_model">product.variant.dimension.value</field>
+        <record id="action_dimension_value" model="ir.actions.act_window">
+            <field name="name">Dimension values</field>
+            <field name="res_model">product.variant.dimension.value</field>
             <field name="view_type">form</field>
-			<field name="view_mode">tree,form</field>
+            <field name="view_mode">tree,form</field>
             <field name="context">{'dimension_value_main_view': True}</field>
-		</record>
-
-        <!-- Views for Dimension types -->
-		<record id="product_variant_multi_dimension_type_tree" model="ir.ui.view">
-			<field name="name">product.variant.multi.dimension.type.tree</field>
-			<field name="model">product.variant.dimension.type</field>
-			<field name="type">tree</field>
-			<field name="arch" type="xml">
-				<tree string="Dimension Types">
-					<field name="name" />
+        </record>
+
+
+        <!-- DIMENSION TYPE -->
+        <record id="product_variant_multi_dimension_type_search" model="ir.ui.view">
+            <field name="name">product.variant.multi.dimension.type.search</field>
+            <field name="model">product.variant.dimension.type</field>
+            <field name="arch" type="xml">
+                <search string="Dimension Type Search">
+                    <field name="name"/>
+                </search>
+            </field>
+        </record>
+
+        <record id="product_variant_multi_dimension_type_tree" model="ir.ui.view">
+            <field name="name">product.variant.multi.dimension.type.tree</field>
+            <field name="model">product.variant.dimension.type</field>
+            <field name="arch" type="xml">
+                <tree string="Dimension Types">
+                    <field name="name" />
                     <field name="description" />
-				</tree>
-			</field>
-		</record>
-
-		<record id="product_variant_multi_dimension_type_form" model="ir.ui.view">
-			<field name="name">product.variant.multi.dimension.type.form</field>
-			<field name="model">product.variant.dimension.type</field>
-			<field name="type">form</field>
-			<field name="arch" type="xml">
-				<form string="Dimension Types">
-					<field name="name" select="1" />
-                    <field name="description" select="2" />
-					<field name="sequence" />
-					<field name="allow_custom_value" select="2" />
-					<field name="mandatory_dimension" select="2" />
-					<field name="option_ids" nolabel="1" colspan="4" >
-                        <tree editable="bottom" string="Dimension Options">
-                            <field name="name" />
-                            <field name="code" />
-                            <field name="sequence" invisible="1"/>
-                        </tree>
-                    </field>
-				</form>
-			</field>
-		</record>
-
-
-        <!-- Default action for Dimension types -->
-		<record id="action_dimension_type" model="ir.actions.act_window">
-			<field name="name">Dimension types</field>
-			<field name="res_model">product.variant.dimension.type</field>
+                </tree>
+            </field>
+        </record>
+
+        <record id="product_variant_multi_dimension_type_form" model="ir.ui.view">
+            <field name="name">product.variant.multi.dimension.type.form</field>
+            <field name="model">product.variant.dimension.type</field>
+            <field name="arch" type="xml">
+                <form string="Dimension Types" version="7.0">
+                    <sheet>
+                        <div class="oe_title">
+                            <label for="name" string="Dimension Type Name" class="oe_edit_only"/>
+                            <h1>
+                                <field name="name" />
+                            </h1>
+                        </div>
+                        <group>
+                            <field name="description" />
+                            <field name="sequence" />
+                            <field name="allow_custom_value" />
+                            <field name="mandatory_dimension" />
+                            <field name="option_ids" nolabel="1" colspan="4"/>
+                        </group>
+                    </sheet>
+                </form>
+            </field>
+        </record>
+
+
+        <record id="action_dimension_type" model="ir.actions.act_window">
+            <field name="name">Dimension Types</field>
+            <field name="res_model">product.variant.dimension.type</field>
             <field name="view_type">form</field>
-			<field name="view_mode">tree,form</field>
+            <field name="view_mode">tree,form</field>
             <field name="context">{'dimension_type_main_view': True}</field>
-		</record>
-
-        <!-- Menu entry for dimension types -->
-		<menuitem id="menu_variant_dimension_types" icon="STOCK_JUSTIFY_FILL" parent="menu_variant_dimension" action="action_dimension_type" />
-
-
-
+        </record>
+
+        <menuitem id="menu_variant_dimension_types" parent="menu_variant_dimension" action="action_dimension_type" />
+
+
+        <!-- PRODUCT TEMPLATE -->
 
 <!-- TODO remove useless view of product.template in the module product or fusion this view with the existing view in product, it's depend how the inheritage on this view will be managed by the other module-->
 
-                                    <!--TODO add a wizard to add the option-->
-                                    <!--<button name="add_some_option" string="Add " type="object" colspan="2"/>-->
+<!--TODO add a wizard to add the option-->
+<!--<button name="add_some_option" string="Add " type="object" colspan="2"/>-->
 
         <record id="product_search_form_view_template" model="ir.ui.view">
             <field name="name">product.search.form.template</field>
             <field name="model">product.template</field>
-            <field name="type">search</field>
             <field name="arch" type="xml">
                 <search string="Product Template">
                    <field name="name"/>
@@ -188,55 +194,62 @@
             </field>
         </record>
 
-
         <record id="product_variant_multi_product_template_form_view" model="ir.ui.view">
             <field name="name">product.variant.multi.product.template.form</field>
             <field name="model">product.template</field>
-            <field name="type">form</field>
             <field name="inherit_id" ref="product.product_template_form_view" />
             <field name="arch" type="xml">
-                <data>
-                    <field name="name" position="after">
+                <xpath expr="//field[@name='categ_id']/.." position="after">
+                    <group>
                         <field name="is_multi_variants"/>
-                    </field>
-
-                    <xpath expr="/form/notebook" position="inside">
-                        <page string="Variants">
-                                <group colspan="1" col="4" attrs="{'invisible':[('is_multi_variants','=',False)]}">
-                                    <field name="dimension_type_ids" nolabel="1" colspan="4" />
-                                    <button name="add_all_option" string="Add All Option" type="object" colspan="2"/>
-                                    <field name="value_ids" nolabel="1" colspan="4" />
-                                </group>
-                                <group  colspan="1" col="4" attrs="{'invisible':[('is_multi_variants','=',False)]}">
-                                    <field name="variant_model_name" colspan="4"/>
-                                    <field name="variant_model_name_separator" colspan="4"/>
-                                    <field name="code_generator" colspan="4"/>
-							        <field name="variant_track_production" colspan="4"/>
-							        <field name="variant_track_incoming" colspan="4"/>
-							        <field name="variant_track_outgoing" colspan="4"/>
-                                    <field name="do_not_generate_new_variant" colspan="4"/>
-                                    <field name="do_not_update_variant" colspan="4"/>
-							        <button name="button_generate_variants" string="Generate / Update variants ->" type="object" colspan="4"/>
-                                </group>
-                                <field name="variant_ids" string="Variants" nolabel="1"  colspan="1">
-                                    <tree string="Variants">
-                                        <field name="code" />
-                                        <field name="name" />
-                                        <field name="variants" string="Dimension Values" />
-                                    </tree>
-                                </field>
-                        </page>
-                    </xpath>
-                </data>
+                    </group>
+                </xpath>
+                <xpath expr="//form/notebook" position="inside">
+                    <page string="Variants">
+                        <group colspan="1" col="4" attrs="{'invisible':[('is_multi_variants','=',False)]}">
+                            <field name="dimension_type_ids" nolabel="1" colspan="4" />
+                            <button name="add_all_option" string="Add All Options" type="object" colspan="2"/>
+                            <field name="value_ids" nolabel="1" colspan="4" />
+                            <field name="variant_model_name" colspan="4"/>
+                            <field name="variant_model_name_separator" colspan="4"/>
+                            <field name="code_generator" colspan="4"/>
+                            <field name="variant_track_production" colspan="4"/>
+                            <field name="variant_track_incoming" colspan="4"/>
+                            <field name="variant_track_outgoing" colspan="4"/>
+                            <field name="do_not_generate_new_variant" colspan="4"/>
+                            <field name="do_not_update_variant" colspan="4"/>
+                            <button name="button_generate_variants" string="Generate / Update Variants" type="object" colspan="4"/>
+                        </group>
+                        <field name="variant_ids" string="Variants" nolabel="1"  colspan="1">
+                            <tree string="Variants">
+                                <field name="code" />
+                                <field name="name" />
+                                <field name="variants" string="Dimension Values" />
+                            </tree>
+                        </field>
+                    </page>
+                </xpath>
             </field>
         </record>
-        
+
+        <record id="product_template" model="ir.actions.act_window">
+            <field name="name">Product Templates</field>
+            <field name="res_model">product.template</field>
+            <field name="view_type">form</field>
+            <field name="domain">[('is_multi_variants','=',True)]</field>
+            <field name="view_mode">tree,form</field>
+        </record>
+
+        <menuitem action="product_template" id="menu_template" parent="product.prod_config_main" />
+
+
+        <!-- PRODUCT VARIANTS -->
+
         <!-- TODO remove useless view of product.product in the module product or move this correct view in product, it's depend how the heritage on this view will be managed by the other module -->
 
         <record id="product_search_form_view_variants" model="ir.ui.view">
             <field name="name">product.search.form.variants</field>
             <field name="model">product.product</field>
-            <field name="type">search</field>
             <field name="inherit_id" ref="product.product_search_form_view"/>
             <field name="arch" type="xml">
                 <field name="categ_id" position="after">
@@ -249,40 +262,46 @@
         <record id="product_variant_form_view" model="ir.ui.view">
             <field name="name">product.variant.form</field>
             <field name="model">product.product</field>
-            <field name="type">form</field>
             <field name="arch" type="xml">
-                <form string="Product Variant">
-                    <field name="name" select="1" required="1"/>
-                    <field name="product_tmpl_id" select="1"/>
-                    <field name="variants" select="1"/>
-                    <field name="default_code" select="1"/>
-                    <field name="active" select="1"/>
-                    <newline />
-                    <notebook colspan="4">
-                        <page string="Dimensions">
-                            <separator string="Dimension Values" colspan="4"/>
-                            <field name="dimension_value_ids" context="{'product_tmpl_id':product_tmpl_id}" nolabel="1" colspan="4"/>
-                        </page>
-                        <page string="Price">
-                            <field name="list_price" string="Template Sale Price" readonly="1"/>
-                            <field name="price_margin" select="1"/>
-                            <field name="price_extra" select="1"/>
-                            <field name="cost_price_extra"/>
-                        </page>
-                        <page string="Lots">
-                            <field name="track_production" />
-                            <field name="track_incoming" />
-                            <field name="track_outgoing" />
-                        </page>
-                    </notebook>
+                <form string="Product Variant" version="7.0">
+                    <sheet>
+                        <div class="oe_title">
+                            <label for="name"/>
+                            <h1>
+                                <field name="name" required="1"/>
+                            </h1>
+                            <label for="product_tmpl_id"/>
+                            <h2>
+                                <field name="product_tmpl_id" />
+                            </h2>
+                        </div>
+                        <group>
+                            <field name="variants" />
+                            <field name="default_code" />
+                            <field name="active" />
+                        </group>
+                        <notebook colspan="4">
+                            <page string="Dimensions">
+                                <separator string="Dimension Values" colspan="4"/>
+                                <field name="dimension_value_ids" context="{'product_tmpl_id':product_tmpl_id}" nolabel="1" colspan="4"/>
+                            </page>
+                            <page string="Prices">
+                                <group>
+                                    <field name="list_price" string="Template Sale Price" readonly="1"/>
+                                    <field name="price_margin" />
+                                    <field name="price_extra" />
+                                    <field name="cost_price_extra"/>
+                                </group>
+                            </page>
+                        </notebook>
+                    </sheet>
                 </form>
             </field>
         </record>
-      
+
         <record id="product_variant_tree_view" model="ir.ui.view">
             <field name="name">product.variant.tree</field>
             <field name="model">product.product</field>
-            <field name="type">tree</field>
             <field name="arch" type="xml">
                 <tree string="Product Variant">
                     <field name="default_code"/>
@@ -294,7 +313,14 @@
                 </tree>
             </field>
         </record>
-    
+
+        <record id="product_variant" model="ir.actions.act_window">
+            <field name="name">Product Variants</field>
+            <field name="res_model">product.product</field>
+            <field name="view_type">form</field>
+            <field name="view_mode">tree,form</field>
+        </record>
+
         <record id="action_variant_tree" model="ir.actions.act_window.view">
             <field name="sequence" eval="10" />
             <field name="view_mode">tree</field>
@@ -309,48 +335,47 @@
             <field name="view_id" ref="product_variant_form_view" />
         </record>
 
+        <menuitem action="product_variant" id="menu_variant" parent="product.prod_config_main" />
+
         <record id="product_normal_variant_form_view" model="ir.ui.view">
             <field name="name">product.normal.variant.form</field>
             <field name="model">product.product</field>
-            <field name="type">form</field>
             <field name="inherit_id" ref="product.product_normal_form_view" />
             <field name="arch" type="xml">
-                <data>
-                    <field name="name" position="attributes">
-                        <attribute name="required">1</attribute>
-                    </field>
-                    <field name="standard_price" position="replace">
-                        <group name='cost_prices' colspan="2" col="4">
-                            <field name="standard_price" attrs="{'readonly':[('cost_method','=','average')]}"/>
-                            <field name="cost_price_extra" groups="product.group_product_variant"/>
-                        </group>
-                    </field>
-                    <group col="2" colspan="2" groups="base.group_extended" position="replace">
-                         <group colspan="2" col="6" name="weight" groups="base.group_extended">
-                            <field name="is_multi_variants" invisible="1"/>
-                            <group colspan="2" col="2">
-                                <separator string="Template Weights" colspan="2"/>
-                                <field digits="(14, 3)" name="volume" attrs="{'readonly':[('type','=','service')]}"/>
-                                <field digits="(14, 3)" name="weight" attrs="{'readonly':[('type','=','service')]}"/>
-                                <field digits="(14, 3)" name="weight_net" attrs="{'readonly':[('type','=','service')]}"/>
-                            </group>
-                            <group colspan="2" col="2" attrs="{'invisible':[('is_multi_variants','=',False)]}">
-                                <separator string="Variant Weights" colspan="2"/>
-                                <field digits="(14, 3)" name="additional_volume" attrs="{'readonly':[('type','=','service')]}"/>
-                                <field digits="(14, 3)" name="additional_weight" attrs="{'readonly':[('type','=','service')]}"/>
-                                <field digits="(14, 3)" name="additional_weight_net" attrs="{'readonly':[('type','=','service')]}"/>
-                            </group>
-                            <group colspan="2" col="2" attrs="{'invisible':[('is_multi_variants','=',False)]}">
-                                <separator string="Total Weights" colspan="2"/>
-                                <field digits="(14, 3)" name="total_volume"/>
-                                <field digits="(14, 3)" name="total_weight"/>
-                                <field digits="(14, 3)" name="total_weight_net"/>
-                            </group>
-                        </group>
-                    </group>
-                </data>
+                <field name="name" position="attributes">
+                    <attribute name="required">1</attribute>
+                </field>
+                <div name="options" position="inside">
+                    <field name="is_multi_variants" readonly="1"/>
+                    <label for="is_multi_variants" />
+                </div>
+                <field name="standard_price" position="replace">
+                    <group name='cost_prices' colspan="2" col="4">
+                        <field name="standard_price" attrs="{'readonly':[('cost_method','=','average')]}"/>
+                        <field name="cost_price_extra" groups="product.group_product_variant"/>
+                    </group>
+                </field>
+                <group name="Weights" position="replace">
+                     <group colspan="4" col="6" name="Weights" groups="product.group_stock_packaging">
+                        <group name="template_weights" string="Template Weights">
+                            <field digits="(14, 3)" name="volume" attrs="{'readonly':[('type','=','service')]}"/>
+                            <field name="weight" attrs="{'readonly':[('type','=','service')]}"/>
+                            <field name="weight_net" attrs="{'readonly':[('type','=','service')]}"/>
+                        </group>
+                        <group name="variant_weights" string="Variant Weights" attrs="{'invisible':[('is_multi_variants','=',False)]}">
+                            <field digits="(14, 3)" name="additional_volume" attrs="{'readonly':[('type','=','service')]}"/>
+                            <field name="additional_weight" attrs="{'readonly':[('type','=','service')]}"/>
+                            <field name="additional_weight_net" attrs="{'readonly':[('type','=','service')]}"/>
+                        </group>
+                        <group name="total_weights" string="Total Weights" attrs="{'invisible':[('is_multi_variants','=',False)]}">
+                            <field digits="(14, 3)" name="total_volume"/>
+                            <field name="total_weight"/>
+                            <field name="total_weight_net"/>
+                        </group>
+                    </group>
+                </group>
             </field>
-        </record>   
-    
+        </record>
+
     </data>
 </openerp>

=== modified file 'product_variant_multi/security/ir.model.access.csv'
--- product_variant_multi/security/ir.model.access.csv	2012-05-16 05:08:08 +0000
+++ product_variant_multi/security/ir.model.access.csv	2013-04-04 09:34:23 +0000
@@ -5,6 +5,3 @@
 "access_product_variant_dimension_type_sale_manager","Full rights on product.variant.dimension.type for sale manager","model_product_variant_dimension_type","base.group_sale_manager",1,1,1,1
 "access_product_variant_dimension_value_sale_manager","Full rights on product.variant.dimension.value for sale manager","model_product_variant_dimension_value","base.group_sale_manager",1,1,1,1
 "access_product_variant_dimension_option_sale_manager","Full rights on product.variant.dimension.option for sale manager","model_product_variant_dimension_option","base.group_sale_manager",1,1,1,1
-"access_product_variant_dimension_type_stock_manager","Full rights on product.variant.dimension.type for stock manager","model_product_variant_dimension_type","stock.group_stock_manager",1,1,1,1
-"access_product_variant_dimension_value_stock_manager","Full rights on product.variant.dimension.value for stock manager","model_product_variant_dimension_value","stock.group_stock_manager",1,1,1,1
-"access_product_variant_dimension_option_stock_manager","Full rights on product.variant.dimension.option for stock manager","model_product_variant_dimension_option","stock.group_stock_manager",1,1,1,1