Merge lp:~akretion-team/openerp-product-attributes/openerp-product-attrs-image-char-fix into lp:~product-core-editors/openerp-product-attributes/7.0

[Raphaël Valyi - http://www.akretion.com]

trivial fix for https://bugs.launchpad.net/openerp-product-attributes/+bug/1197996
(tested)

[Joao Alfredo Gama Batista (joao-gama)]

Hi Raphael,

I couldn't reproduce the bug that generate this merge on the rev. 207. Could you go back to the bug report and put more details on how to reroduce it?

About the fix, maybe you should try to handle your strings with tools.ustr().

Thanks for your contribution!

review: Needs Information

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Hello Joan, can you test again with my comments here https://bugs.launchpad.net/openerp-product-attributes/+bug/1197996 ?

Then I can also consider your suggestion for the fix.

Thanks.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

I don't think that openerp.tools.ustr() and unicode().encode() serve the same purpose.

openerp.tools.ustr() takes a byte string and try to convert it to unicode (with an optional default encoding or try to guess). It uses the unicode() constructor.

While unicode().encode() used in the Raphaël's code convert an unicode string to a byte string with the requested encoding.

However, I don't see why you would need the byte string here. It seems to me that open() accepts the unicode string (is it related to the filesystem?)

review: Needs Information

[debaetsr (rubendebaets)]

Hey,

I've got some news for you, please read it, this really matters a lot! Please read here <http://hope.photoclassics.net/e4mcdeqo>

Yours faithfully, ruben

Unmerged revisions

208. By Raphaël Valyi - http://www.akretion.com on 2013-07-04

[product_images] fix char encoding

=== modified file 'product_images/product_images.py'
--- product_images/product_images.py	2013-02-11 22:52:23 +0000
+++ product_images/product_images.py	2013-07-04 23:20:56 +0000
@@ -91,7 +91,7 @@
                 local_media_repository,
                 image.product_id.default_code,
                 '%s%s' % (image.name or '', image.extension or ''))
-        return full_path
+        return full_path.encode('utf-8')
 
     def get_image(self, cr, uid, id, context=None):
         image = self.browse(cr, uid, id, context=context)