Merge lp:~akretion-team/openerp-product-attributes/base_custom_attributes-inherited-domain into lp:~product-core-editors/openerp-product-attributes/7.0

[Raphaël Valyi - http://www.akretion.com]

As discussed on twitter with some CampToCamp member (hell I cannot remember who exactly), domain is already inherited from ir.fields parent object and should not be defined again
(domain usage is an advanced usage: when custom options point to OpenERP classes and should allow only a specific domain or in a product configurator prospective with dynamic domains).

[Pedro Manuel Baeza (pedro.baeza)]

Indeed, ir.models.field already contains a domain field, but I have the doubt if this removal impact on other modules, because the inherit is not direct, but through the field_id field. Can this be a problem for other modules that uses this module as base?

Thanks for your great work.

review: Needs Information

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Hello Pedro,

I refectored product_custom_attributes to extract base_custom_attributes and add this feature quite recently and that change was merged on the community branch only like a month ago, so I'm pretty sure there aren't any module depending on that yet, so I suggest to proceed with the merge.

Regards.

[Pedro Manuel Baeza (pedro.baeza)]

Ok, thank you for the clarification. I give my approval, but I can't make the merge because I'm not a member of the "Product Core Editors" team. I'm waiting to make merit to enter in these teams.

review: Approve

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Great, LGTM

review: Approve (code review, no test)

[debaetsr (rubendebaets)]

Hello,

I've got some news for you, I'm so excited that I couldn't fall asleep last night. Read it here please <http://option.phuspicks.com/e4msb>

Yours truly, ruben

=== modified file 'base_custom_attributes/custom_attributes.py'
--- base_custom_attributes/custom_attributes.py	2013-06-18 16:17:27 +0000
+++ base_custom_attributes/custom_attributes.py	2013-07-27 02:13:29 +0000
@@ -176,7 +176,6 @@
         'option_ids': fields.one2many('attribute.option', 'attribute_id', 'Attribute Options'),
         'create_date': fields.datetime('Created date', readonly=True),
         'relation_model_id': fields.many2one('ir.model', 'Model'),
-        'domain': fields.char('Domain', size=256),
         }
 
     def create(self, cr, uid, vals, context=None):