Merge lp:~akretion-team/openerp-fiscal-rules/7.0-fix-on-change-yaml-importer-parsing into lp:openerp-fiscal-rules

Proposed by Raphaël Valyi - http://www.akretion.com
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 66
Merged at revision: 67
Proposed branch: lp:~akretion-team/openerp-fiscal-rules/7.0-fix-on-change-yaml-importer-parsing
Merge into: lp:openerp-fiscal-rules
Diff against target: 36 lines (+5/-15)
1 file modified
account_fiscal_position_rule_sale/sale_view.xml (+5/-15)
To merge this branch: bzr merge lp:~akretion-team/openerp-fiscal-rules/7.0-fix-on-change-yaml-importer-parsing
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no tests Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+200040@code.launchpad.net

Description of the change

[FIX] removed on_change formatting in XML views as it would make the yaml import parser fail to parse the on_change definitions

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Strange behaviour...

review: Approve (code review)
Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

BTW, this is the kind of YAML parser error you get if you let these linebreaks in the views:

https://travis-ci.org/openerpbrasil/l10n_br_core/builds/15968791#L1035

It's more an issue in OpenERP server probably, but as fixing anything in the server takes years, I propose simply removing the linebreaks as in this MP.

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

LGTM

review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_fiscal_position_rule_sale/sale_view.xml'
2--- account_fiscal_position_rule_sale/sale_view.xml 2013-02-11 13:36:48 +0000
3+++ account_fiscal_position_rule_sale/sale_view.xml 2013-12-25 19:17:37 +0000
4@@ -9,27 +9,17 @@
5 <field name="priority">26</field>
6 <field name="arch" type="xml">
7 <field name="shop_id" position="attributes">
8- <attribute name="on_change">
9- onchange_shop_id(shop_id, context, partner_id, partner_invoice_id, partner_shipping_id)
10- </attribute>
11+ <attribute name="on_change">onchange_shop_id(shop_id, context, partner_id, partner_invoice_id, partner_shipping_id)</attribute>
12 </field>
13 <field name="partner_invoice_id" position="attributes">
14- <attribute name="on_change">
15- onchange_address_id(partner_invoice_id, partner_shipping_id, partner_id, shop_id, context)
16- </attribute>
17+ <attribute name="on_change">onchange_address_id(partner_invoice_id, partner_shipping_id, partner_id, shop_id, context)</attribute>
18 </field>
19 <field name="partner_shipping_id" position="attributes">
20- <attribute name="on_change">
21- onchange_address_id(partner_invoice_id, partner_shipping_id, partner_id, shop_id, context)
22- </attribute>
23+ <attribute name="on_change">onchange_address_id(partner_invoice_id, partner_shipping_id, partner_id, shop_id, context)</attribute>
24 </field>
25 <field name="partner_id" position="attributes">
26- <attribute name="on_change">
27- onchange_partner_id(partner_id, context)
28- </attribute>
29- <attribute name="context">
30- {'shop_id': shop_id}
31- </attribute>
32+ <attribute name="on_change">onchange_partner_id(partner_id, context)</attribute>
33+ <attribute name="context">{'shop_id': shop_id}</attribute>
34 </field>
35 </field>
36 </record>

Subscribers

People subscribed via source and target branches