Merge lp:~akretion-team/openerp-connector/connector-base-product into lp:~openerp-connector-core-editors/openerp-connector/7.0

Proposed by David BEAL (ak)
Status: Merged
Approved by: Guewen Baconnier @ Camptocamp
Approved revision: 617
Merged at revision: 624
Proposed branch: lp:~akretion-team/openerp-connector/connector-base-product
Merge into: lp:~openerp-connector-core-editors/openerp-connector/7.0
Diff against target: 86 lines (+71/-0)
3 files modified
connector_base_product/__init__.py (+1/-0)
connector_base_product/__openerp__.py (+41/-0)
connector_base_product/product_view.xml (+29/-0)
To merge this branch: bzr merge lp:~akretion-team/openerp-connector/connector-base-product
Reviewer Review Type Date Requested Status
Benoit Guillot - http://www.akretion.com (community) Approve
Guewen Baconnier @ Camptocamp Approve
Review via email: mp+204706@code.launchpad.net

Description of the change

[ADD] connector_base_product module to avoid ecommerce addons dependency for product synchro

To post a comment you must log in.
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Hi,

Thanks.

Some required changes:
 - add 'product' in depends
 - Change the author and copyright
 - remove "'Application': True"
 - Change category to 'Connector'
 - remove the 2 extraneous "=" below "Connector Base Product" (rst wont be parsed)

review: Needs Fixing
Revision history for this message
David BEAL (ak) (davidbeal) wrote :

Fixed

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Thanks. Can you change the category as well?
Is it intended that you added on unrelated change? (not that I disagree with the change, but it is another topic)

Revision history for this message
David BEAL (ak) (davidbeal) wrote :

which category do you want to use, i m not a category expert ;-)

yes change in queue.job view is another story but you validated me 4 month ago, and I have not a lot of time to do another merge request.

If you want i can cancel it

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Upper:
> - Change category to 'Connector'

> yes change in queue.job view is another story but you validated me 4 month ago, and I have not a lot of time to do another merge request.

As just said, this is not a matter of my agreement, I agreed with this change. Arguing about that would take as much time as proposing a proper merge. (BTW do you know the commands "bzr lp-propose" and "bzr lp-open"? I think you should give them a try, really it takes seconds to propose a branch)

617. By David BEAL (ak)

[FIX] fix __openerp__.py

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Thanks a lot

review: Approve
Revision history for this message
Benoit Guillot - http://www.akretion.com (benoit-guillot-z) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'connector_base_product'
2=== added file 'connector_base_product/__init__.py'
3--- connector_base_product/__init__.py 1970-01-01 00:00:00 +0000
4+++ connector_base_product/__init__.py 2014-02-04 16:39:29 +0000
5@@ -0,0 +1,1 @@
6+# -*- coding: utf-8 -*-
7
8=== added file 'connector_base_product/__openerp__.py'
9--- connector_base_product/__openerp__.py 1970-01-01 00:00:00 +0000
10+++ connector_base_product/__openerp__.py 2014-02-04 16:39:29 +0000
11@@ -0,0 +1,41 @@
12+# -*- coding: utf-8 -*-
13+##############################################################################
14+#
15+# Author: David BEAL, Copyright Akretion, 2014
16+#
17+# This program is free software: you can redistribute it and/or modify
18+# it under the terms of the GNU Affero General Public License as
19+# published by the Free Software Foundation, either version 3 of the
20+# License, or (at your option) any later version.
21+#
22+# This program is distributed in the hope that it will be useful,
23+# but WITHOUT ANY WARRANTY; without even the implied warranty of
24+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
25+# GNU Affero General Public License for more details.
26+#
27+# You should have received a copy of the GNU Affero General Public License
28+# along with this program. If not, see <http://www.gnu.org/licenses/>.
29+#
30+##############################################################################
31+
32+{'name': 'Connector Base Product',
33+ 'version': '1.0',
34+ 'author': 'Openerp Connector Core Editors',
35+ 'website': 'http://openerp-connector.com',
36+ 'license': 'AGPL-3',
37+ 'category': 'Connector',
38+ 'description': """
39+Connector Base Product
40+======================
41+
42+Add 'Connector' tab to product view
43+""",
44+ 'depends': [
45+ 'connector',
46+ 'product',
47+ ],
48+ 'data': [
49+ 'product_view.xml'
50+ ],
51+ 'installable': True,
52+}
53
54=== added file 'connector_base_product/product_view.xml'
55--- connector_base_product/product_view.xml 1970-01-01 00:00:00 +0000
56+++ connector_base_product/product_view.xml 2014-02-04 16:39:29 +0000
57@@ -0,0 +1,29 @@
58+<?xml version="1.0" encoding="utf-8"?>
59+
60+<!--
61+ Copyright (C) 2013 Akretion (http://www.akretion.com/)
62+ The licence is in the file __openerp__.py
63+-->
64+
65+<openerp>
66+<data>
67+
68+<!--This is a product inherited form that will be dynamically populated-->
69+<record id="product_normal_form_view" model="ir.ui.view">
70+ <field name="name">product.product.form</field>
71+ <field name="model">product.product</field>
72+ <field name="inherit_id" ref="product.product_normal_form_view" />
73+ <field name="arch" type="xml">
74+ <xpath expr="/form/sheet/notebook" position="inside">
75+ <!-- change the invisible attribute to 0 when used
76+ in submodules -->
77+ <page string="Connectors" name="connector" invisible="1">
78+ </page>
79+ </xpath>
80+ </field>
81+</record>
82+
83+
84+
85+</data>
86+</openerp>