Merge lp:~akretion-team/multi-company/multi-company-action-user into lp:multi-company

[Benoit Guillot - http://www.akretion.com]

Hello,

I propose a new module in this branch : multi_company_action_user

This module is a generic module. It adds a field on the company : automatic_action_user_id.

This field defines a user for a company that will be used in the code for intercompany automatic actions. For instance, automatic intercompany invoices, sales ...

Best regards.

Benoît

[Stefan Rijnhart (Opener) (stefan-opener)]

I expect that the use of this module will become clear in future modules, so I only have a couple of nits:

- better to remove the empty lines at the end of __init__.py
- l.114..119 will probably look more elegant if you break the line after the parenthesis and align with the 'o' in 'automatic'.
- l. 127 you can use orm.except_orm instead, so that you do not have to import osv at all

review: Needs Fixing

[lp:~akretion-team/multi-company/multi-company-action-user]

6. By Benoit Guillot - http://www.akretion.com on 2013-08-13

[FIX] clean code

[Benoit Guillot - http://www.akretion.com (benoit-guillot-z)]

Thanks Stefan for the review.

Indeed, the field is used in other modules that I will propose for merging too.

I made the changes ask in your comment.

[Stefan Rijnhart (Opener) (stefan-opener)]

Thanks for the changes!

review: Approve

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

LGTM, The same as Stefan, I do not see the use of that field and I'm curious about the rest of modules here.

review: Approve (code review, no tests)

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Eric Caudal has said that Elico is working on some modules for providing multi-company documents automations, so I would like to know if this module has something to do with that or is another work in progress for the same purpose. If it's so, I would recommend to talk each other to shyncronize you to avoid duplicating efforts.

Regards.

review: Needs Information

[Sylvain LE GAL (GRAP) (sylvain-legal)]

Hi,

There wasn't any answer to Pedro's question. Does this MP need review ?

Regards.

[Ana Juaristi Olalde (ajuaristio)]

If this could help... Joël's questions help try:

When it's necesary creating an automated document from one company to another one and user working on origin company has not permission on the destiny document, any creation action produces an error so I think the field is to avoid using hardcode user_id = 1 to be passed as parameter between functions.

Just my 2 cents.

I just aprove the idea and code. Not tested code.

If you find it usefull we have got several multi-company processes created for 6.1. They have been made especifically for a customer with a very specific proccesses but maybe some code/ideas/functional aproach could be reused to build generic Odoo's full multicompany requirements. Just an idea.

I published several screencast about requirements and solution we have built (it's in spanish, sorry for that):
http://www.aula-openerp.com/soluciones-específicas-61-3/procesos-intercompañía-entre-3-empresas/
Our modules are published and available, but please contact me if you need more information about them.

review: Approve

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

Could you update the description of the module to make it clear that there is no magic done in the module.

Suggestion:

'description': """Defines a user to be used for automatic action

This module adds a field 'automatic_action_user_id'
on the company to define a specific user to be used for the automatic actions. This field can
then be used by other modules defining such actions."""

Even then, the concept of "automatic action" is not clear to me. An example would be welcome.

review: Needs Information (code review, no tests)

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

Hello,

The management of the project has moved to Github: https://github.com/OCA/multi-company

Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on how to proceed.

Thanks for contributing to the project

review: Needs Resubmitting

Unmerged revisions

6. By Benoit Guillot - http://www.akretion.com on 2013-08-13

[FIX] clean code

5. By Benoit Guillot - http://www.akretion.com on 2013-08-08

[ADD] new module to add a specific user to the company to make actions on this company

=== added directory 'multi_company_action_user'
=== added file 'multi_company_action_user/__init__.py'
--- multi_company_action_user/__init__.py	1970-01-01 00:00:00 +0000
+++ multi_company_action_user/__init__.py	2013-08-13 08:36:36 +0000
@@ -0,0 +1,23 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#                                                                             #
+#   multi_company_action_user for OpenERP                                     #
+#   Copyright (C) 2013 Akretion Benoît GUILLOT <[e-mail]>  #
+#                                                                             #
+#   This program is free software: you can redistribute it and/or modify      #
+#   it under the terms of the GNU Affero General Public License as            #
+#   published by the Free Software Foundation, either version 3 of the        #
+#   License, or (at your option) any later version.                           #
+#                                                                             #
+#   This program is distributed in the hope that it will be useful,           #
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of            #
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the             #
+#   GNU Affero General Public License for more details.                       #
+#                                                                             #
+#   You should have received a copy of the GNU Affero General Public License  #
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.     #
+#                                                                             #
+###############################################################################
+
+import res_company
+

=== added file 'multi_company_action_user/__openerp__.py'
--- multi_company_action_user/__openerp__.py	1970-01-01 00:00:00 +0000
+++ multi_company_action_user/__openerp__.py	2013-08-13 08:36:36 +0000
@@ -0,0 +1,41 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#                                                                             #
+#   multi_company_action_user for OpenERP                                     #
+#   Copyright (C) 2013 Akretion Benoît GUILLOT <[e-mail]>  #
+#                                                                             #
+#   This program is free software: you can redistribute it and/or modify      #
+#   it under the terms of the GNU Affero General Public License as            #
+#   published by the Free Software Foundation, either version 3 of the        #
+#   License, or (at your option) any later version.                           #
+#                                                                             #
+#   This program is distributed in the hope that it will be useful,           #
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of            #
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the             #
+#   GNU Affero General Public License for more details.                       #
+#                                                                             #
+#   You should have received a copy of the GNU Affero General Public License  #
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.     #
+#                                                                             #
+###############################################################################
+
+
+
+{
+    'name': 'multi_company_action_user',
+    'version': '0.1',
+    'category': 'Generic Modules/Others',
+    'license': 'AGPL-3',
+    'description': """This module adds a field 'automatic_action_user_id' """
+    """on the company to define a specific user to be used for the automatic actions.""",
+    'author': 'Akretion',
+    'website': 'http://www.akretion.com/',
+    'depends': ['base'], 
+    'data': [
+           'res_company_view.xml',
+    ],
+    'demo': [],
+    'installable': True,
+    'active': False,
+}
+

=== added file 'multi_company_action_user/res_company.py'
--- multi_company_action_user/res_company.py	1970-01-01 00:00:00 +0000
+++ multi_company_action_user/res_company.py	2013-08-13 08:36:36 +0000
@@ -0,0 +1,43 @@
+# -*- coding: utf-8 -*-
+###############################################################################
+#                                                                             #
+#   multi_company_action_user for OpenERP                                     #
+#   Copyright (C) 2013 Akretion Benoît GUILLOT <[e-mail]>  #
+#                                                                             #
+#   This program is free software: you can redistribute it and/or modify      #
+#   it under the terms of the GNU Affero General Public License as            #
+#   published by the Free Software Foundation, either version 3 of the        #
+#   License, or (at your option) any later version.                           #
+#                                                                             #
+#   This program is distributed in the hope that it will be useful,           #
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of            #
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the             #
+#   GNU Affero General Public License for more details.                       #
+#                                                                             #
+#   You should have received a copy of the GNU Affero General Public License  #
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.     #
+#                                                                             #
+###############################################################################
+
+from openerp.osv import fields, orm
+from tools.translate import _
+
+
+class res_company(orm.Model):
+    _inherit = "res.company"
+    
+    _columns = {
+        'automatic_action_user_id': fields.many2one(
+            'res.users', 'Automatic actions user',
+            help='This user is the one used for all the actions '
+                 '(create(), write(),...) to make on this company.'),
+    }
+
+    def get_company_action_user(self, cr, uid, company_id, context=None):
+        user_id = self.read(cr, uid, company_id,
+                            ['automatic_action_user_id'],
+                            context=context)['automatic_action_user_id']
+        if not user_id:
+            raise orm.except_orm(_('Error !'),
+                                 _('You need to define an automatic action user for the company !'))
+        return user_id[0]

=== added file 'multi_company_action_user/res_company_view.xml'
--- multi_company_action_user/res_company_view.xml	1970-01-01 00:00:00 +0000
+++ multi_company_action_user/res_company_view.xml	2013-08-13 08:36:36 +0000
@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+  multi_company_action_user for OpenERP
+  Copyright (C) 2013 Akretion Benoît GUILLOT <[e-mail]>
+  The licence is in the file __openerp__.py
+-->
+
+<openerp>
+    <data>
+    
+        <!-- INHERITED VIEW FOR THE OBJECT : res_company -->
+
+        <record id="res_company_view_form" model="ir.ui.view">
+            <field name="name">base_multi_company.res_company.view_form</field>
+            <field name="model">res.company</field>
+            <field name="inherit_id" ref="base.view_company_form" />
+            <field name="type">form</field>
+            <field name="arch" type="xml">
+                <data>
+                    <page string="Configuration" position="inside">
+                        <separator string="Multi-company" colspan="4"/>
+                        <field name="automatic_action_user_id"/>
+                    </page> 
+                </data>
+            </field>
+        </record>
+
+    </data>
+</openerp>