Code review comment for lp:~akretion-team/carriers-deliveries/7-change-generate_shipping_labels-arg-dbl

Revision history for this message
Leonardo Pistone (lepistone) wrote :

I agree with Yannick there is a convention of sorts of passing lists of integers.

Since we will soon switch to the new API, I do not have a strong opinion now.

In the future (new API?), I would prefer passing some form of instance (and not ids) because in an isolated test you can easily build a test double. On the other hand, with the list of ids you would need to mock self.pool out, which is probably a pain.

review: Abstain

« Back to merge proposal