Code review comment for lp:~akretion-team/banking-addons/trunk-banking-addons-sepa

Revision history for this message
St├ęphane Bidoul (Acsone) (sbi) wrote :

Nothing blocking on my side, so I approve.

I understand the philosophy behind the validate button. A help text would clarify for new users.

Regarding the lack of a bank account, it's not blocking either, but I had the impression it revealed an issue with the XSD validation, since I could generate an XML without the bank account which is invalid according to the schema. Let me know if that rings a bell, otherwise I'll dig deeper.

review: Approve (test)

« Back to merge proposal