Code review comment for lp:~akretion-team/banking-addons/trunk-banking-addons-sepa

Revision history for this message
St├ęphane Bidoul (Acsone) (sbi) wrote :

Hi,

I just validated PAIN.001.001.03 with ING's validation service.

I've noticed a couple of minor usability issues:
- the role of the Validate button in the last step of the "Make payment" wizard is unclear (it closes the window before you have a chance to save the xml file)
- if by mistake you select payments without a bank account (stupid, but allowed by the payment order wizard), you get a stack trace
- I quickly adapted the code to avoid the stack trace when the bank account is missing, which oviously lead to a non compliant xml file, but the XSD validation step did not raise the error; I've not had time to dig deeper yet.

Great job, Alexis!

-sbi

« Back to merge proposal