Code review comment for lp:~akretion-team/banking-addons/trunk-banking-addons-sepa

Revision history for this message
Alexis de Lattre (alexis-via) wrote :

Dear Stéfan,

> but you may be aware that the specs leave room enough for their own dialect of the standard

In fact, from my experience, if all banks respect the guidelines of the European Payments Council (, we shouldn't have several dialects to implement, because these guidelines are pretty accurate. We'll see if we are confronted to such problems ; in this case, we will modularise the code in order to be able to inherit the generation of the XML file.

I'll try to find some time in the coming days to clean-up the function _validate_iban which should avoid the big block of code in the POT file. By the way, do you think that it's necessary the validate the IBAN in the generation of the XML file ? The IBAN is already validated when we enter it in OpenERP, so it may not be necessary to validate a second time ? Or should be consider it better to validate it a second time ? If don't remember what y commented out this code. I must say that I spend most of my time reading specs, checking the XML and doing tests with the bank... and probably not enough time on the code itself.

« Back to merge proposal