Merge lp:~akretion-team/banking-addons/bank-statement-reconcile-70-uniq-name into lp:banking-addons/bank-statement-reconcile-70

[Sébastien BEAU - http://www.akretion.com]

When you import bank statement automatically it's great to avoid duplicated bank statement so having a constainte on the name can be a good solution.
Now the question is "the name should be uniq by default?". If no, I will create a specific module for that.

Thanks

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Hi,

Thanks for the contrib ! In fact, I agree with you, but I'd rather prefer a unique name BY COMPANY.

Would you please change the constraint ?

Thanks,

Joël

review: Needs Fixing (code review, no tests)

[lp:~akretion-team/banking-addons/bank-statement-reconcile-70-uniq-name]

104. By Sébastien BEAU - http://www.akretion.com on 2013-12-11

[FIX] fix uniq name constraint, should work in multi-company

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

Fixed! Thanks for the review

[Frederic Clementi - Camptocamp (frederic-clementi)]

Very good idea. So far bank statement name was pretty useless. so it makes definitely sens to me and easy to reconcile processe for e-commerce flow for ex.

review: Approve (functionnal)

[Omar (Pexego) (omar7r)]

LGTM

review: Approve (code review)

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

LGTM now, thanks !

review: Approve (code review, no tests)

=== modified file 'account_statement_ext/statement.py'
--- account_statement_ext/statement.py	2013-10-16 08:58:12 +0000
+++ account_statement_ext/statement.py	2013-12-11 16:01:21 +0000
@@ -111,6 +111,11 @@
     _constraints = [
         (_check_partner, "You need to put a partner if you tic the 'Force partner on bank move'!", []),
     ]
+    
+    _sql_constraints = [
+        ('name_uniq', 'unique (name, company_id)', 'The name of the bank statement must be unique !')
+    ]
+
 
 
 class AccountBankSatement(Model):