Merge lp:~akretion-team/banking-addons/bank-statement-reconcile-70-internal-transfers into lp:banking-addons/bank-statement-reconcile-70

Proposed by Sébastien BEAU - http://www.akretion.com
Status: Rejected
Rejected by: Sébastien BEAU - http://www.akretion.com
Proposed branch: lp:~akretion-team/banking-addons/bank-statement-reconcile-70-internal-transfers
Merge into: lp:banking-addons/bank-statement-reconcile-70
Diff against target: 26 lines (+5/-0)
2 files modified
account_statement_ext/statement.py (+4/-0)
account_statement_ext/statement_view.xml (+1/-0)
To merge this branch: bzr merge lp:~akretion-team/banking-addons/bank-statement-reconcile-70-internal-transfers
Reviewer Review Type Date Requested Status
Sébastien BEAU - http://www.akretion.com Disapprove
Joël Grand-Guillaume @ camptocamp code review, no tests Needs Information
Frederic Clementi - Camptocamp Pending
Review via email: mp+197773@code.launchpad.net

Description of the change

Hi
In some case like CB import you need to store on the profile the internal transfers account.
Maybe adding this field directly in the base module is not a good idea, I let's you decide.
If not I will create a small module that add this field.

Thanks

To post a comment you must log in.
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi,

Thanks for the contribs ! Where/in which situation do this field is used ?

Regards

review: Needs Information (code review, no tests)
Revision history for this message
Sébastien BEAU - http://www.akretion.com (sebastien.beau) wrote :

After a talk with Frederic, we will not use this account anymore So I remove this merge.

review: Disapprove

Unmerged revisions

103. By Sébastien BEAU - http://www.akretion.com

[IMP] add internal account transfers

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_statement_ext/statement.py'
2--- account_statement_ext/statement.py 2013-10-16 08:58:12 +0000
3+++ account_statement_ext/statement.py 2013-12-04 18:02:13 +0000
4@@ -100,6 +100,10 @@
5 'profile_id',
6 'Bank Statement Imported'),
7 'company_id': fields.many2one('res.company', 'Company'),
8+ 'internal_account_transfer_id': fields.many2one('account.account',
9+ 'Internal Account Transfer',
10+ help="Choose the default account for internal\
11+ bank transfer"),
12 }
13
14 def _check_partner(self, cr, uid, ids, context=None):
15
16=== modified file 'account_statement_ext/statement_view.xml'
17--- account_statement_ext/statement_view.xml 2013-06-28 15:00:20 +0000
18+++ account_statement_ext/statement_view.xml 2013-12-04 18:02:13 +0000
19@@ -16,6 +16,7 @@
20 <field name="commission_account_id" />
21 <field name="commission_analytic_id" />
22 <field name="receivable_account_id" />
23+ <field name="internal_account_transfer_id"/>
24 <field name="force_partner_on_bank"/>
25 <field name="balance_check"/>
26 <field name="bank_statement_prefix"/>

Subscribers

People subscribed via source and target branches