Code review comment for lp:~akretion-team/banking-addons/account_statement_base_import_conversion_dict

Revision history for this message
Florian da Costa (florian-dacosta) wrote :

Is it possible to have news for this MP?

I guess the name of the keyword is not important to me, it can be extra_field.
The important thing is to move the conversion_dict containing the file's fields from file_parser to generic parser.
Because, the goal of the file_parser is not to parse a particular file mais should be used for files very differents which could eventually not contain 'ref', 'label', 'amount'... right?

So the fields'name of the file should always be in the custom parser (or generic parser).

Or maybe I mis-understood the goal of these parsers.
Thanks

« Back to merge proposal