Code review comment for lp:~akretion-team/banking-addons/account_statement_base_import_conversion_dict

Revision history for this message
Florian da Costa (florian-dacosta) wrote :

Well, the self.conversion_dict is initialized in the file_parser by the argument coming from the generic parser, that's why I don't understand why we are talking of "extra" fields.

And the name's changement comes from a recent commit :
http://bazaar.launchpad.net/~banking-addons-team/banking-addons/bank-statement-reconcile-70/revision/94#account_statement_base_import/parser/file_parser.py

I thought it was a mistake.

I re-changed the keword argument for extra_field, is it ok now?

« Back to merge proposal