Banking Addons

Code review comment for lp:~akretion-team/banking-addons/70-sepa-trf-dd-updates

  1. 70-sepa-trf-dd-updates
  2. Merge into banking-addons-70
Revision history for this message
Stéphane Bidoul (Acsone) (sbi) wrote :

Thanks Alexis and Luc for this great effort.

I made a quick test of account_banking_sepa_credit_transfer and it looks good.

In combination with base_iban_bic_not_required however, it complains with Cannot compute 'Debtor BIC' or 'Creditor BIC'. the PAIN xsd have the BIC elements optional. Can you fix that one?

On the nitpicking side, I noticed a few "return True" and the end of generate_*_block methods which are unncessary.

review: Needs Fixing (sct test)

« Back to merge proposal