Code review comment for lp:~akretion-team/banking-addons/70-sepa-trf-dd-updates

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi,

first of all sorry for my absense on the community front, I have been too busy with first of January deadlines. Hope to show my face more often soon.

So I just had a quick glance and I must thank you Alexis and Luc for your great work. Just one thought about the removal of the communication2 field from the payment line view: does SEPA not allow additional comments on the order lines? And if it really doesn't, maybe we could make the payment view a little bit more dynamic depending on the payment type in a future proposal. Could you leave it in for now?

A cosmetic thing: it seems that remittance_info_unstructured_2_100 should be called remittance_info_structured_2_100

review: Needs Information

« Back to merge proposal