Merge lp:~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls into lp:~account-report-core-editor/account-financial-report/7.0

Proposed by Alexis de Lattre
Status: Merged
Merged at revision: 89
Proposed branch: lp:~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls
Merge into: lp:~account-report-core-editor/account-financial-report/7.0
Diff against target: 16 lines (+3/-3)
1 file modified
account_financial_report_webkit_xls/report/trial_balance_xls.py (+3/-3)
To merge this branch: bzr merge lp:~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls
Reviewer Review Type Date Requested Status
Stéphane Bidoul (Acsone) (community) code review and test Approve
Pedro Manuel Baeza code review Approve
Alexandre Fayolle - camptocamp code review, no test Approve
Review via email: mp+217063@code.launchpad.net

Description of the change

Fix for bug 1274194 : in the XLS version of the Trial balance, the forumula of the "Balance" column was wrong when "Filter by date" was used ! So the numbers were wrong in the report... it's critical bug :)

To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM, code wise.

review: Approve (code review, no test)
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM.

Regards.

review: Approve (code review)
Revision history for this message
Stéphane Bidoul (Acsone) (sbi) wrote :

Thanks!

review: Approve (code review and test)
Revision history for this message
Luc De Meyer (Noviat) (luc-demeyer) wrote :

Approve - code review and test

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_financial_report_webkit_xls/report/trial_balance_xls.py'
2--- account_financial_report_webkit_xls/report/trial_balance_xls.py 2013-10-31 18:01:41 +0000
3+++ account_financial_report_webkit_xls/report/trial_balance_xls.py 2014-04-24 14:39:26 +0000
4@@ -218,9 +218,9 @@
5 ('account', account_span, 0, 'text', current_account.name),
6 ]
7 if _p.comparison_mode == 'no_comparison':
8-
9- debit_cell = rowcol_to_cell(row_pos, 3)
10- credit_cell = rowcol_to_cell(row_pos, 4)
11+
12+ debit_cell = rowcol_to_cell(row_pos, 4)
13+ credit_cell = rowcol_to_cell(row_pos, 5)
14 bal_formula = debit_cell + '-' + credit_cell
15
16 if _p.initial_balance_mode: