Code review comment for lp:~akopytov/percona-xtrabackup/use-dbd-mysql-in-innobackupex
Revision history for this message
| Alexey Kopytov (akopytov) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
Changes made:
- s/$@/$EVAL_ERROR/g. I didn't do the same for CHILD_ERROR, as we have plenty of existing code using $!, and that would blow the diff for this change unnecessarily.
- rewrote the DBD::mysql detection code as suggested
- rewrote "$rc = 255 if $@;" constructs as suggested ("if ($EVAL_ERROR) {...}")
- replaced "and" with "&&" in the existing code touched by this patch.
I have also reported bug #1116177 as a followup to the "use warnings FATAL => 'all'" suggestion, as that seems to reveal a couple of bugs in the existing code which should be fixed in all branches.
Jenkins build with the updated branch: http://