Merge lp:~akopytov/percona-xtrabackup/bug943750-2.1 into lp:percona-xtrabackup/2.1

Proposed by Alexey Kopytov
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 678
Proposed branch: lp:~akopytov/percona-xtrabackup/bug943750-2.1
Merge into: lp:percona-xtrabackup/2.1
Diff against target: 43 lines (+27/-1)
2 files modified
innobackupex (+1/-1)
test/t/bug943750.sh (+26/-0)
To merge this branch: bzr merge lp:~akopytov/percona-xtrabackup/bug943750-2.1
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+186999@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) wrote :
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Self-approving, trivial change.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'innobackupex'
2--- innobackupex 2013-09-16 17:21:44 +0000
3+++ innobackupex 2013-09-23 10:52:48 +0000
4@@ -251,7 +251,7 @@
5 my $src_name;
6 my $dst_name;
7 my $win = ($^O eq 'MSWin32' ? 1 : 0);
8-my $CP_CMD = ($win eq 1 ? "copy /Y" : "cp -p");
9+my $CP_CMD = ($win eq 1 ? "copy /Y" : "cp");
10 my $xtrabackup_binary_file = 'xtrabackup_binary';
11 my $xtrabackup_pid_file = 'xtrabackup_pid';
12 my %rsync_files_hash;
13
14=== added file 'test/t/bug943750.sh'
15--- test/t/bug943750.sh 1970-01-01 00:00:00 +0000
16+++ test/t/bug943750.sh 2013-09-23 10:52:48 +0000
17@@ -0,0 +1,26 @@
18+################################################################################
19+# Bug #943750: innobackupex doesn't backup to nfs mount point
20+################################################################################
21+
22+# Create a fake cp that will fail if '-p' is passed by innobackupex
23+
24+cat >$topdir/cp <<"EOF"
25+#!/bin/bash
26+
27+args=""
28+while (( "$#" ))
29+do
30+ if [ "$1" = "-p" ]
31+ then
32+ echo "'-p' passed as an argument to 'cp'!"
33+ exit 1
34+ fi
35+ args="$args $1"
36+ shift
37+done
38+/bin/cp $args
39+EOF
40+
41+chmod +x $topdir/cp
42+
43+PATH=$topdir:$PATH . inc/xb_local.sh

Subscribers

People subscribed via source and target branches

to all changes: