Merge lp:~akopytov/percona-xtrabackup/bug809073-1.7 into lp:percona-xtrabackup/2.0

Proposed by Alexey Kopytov on 2011-10-21
Status: Merged
Approved by: Stewart Smith on 2011-10-24
Approved revision: 325
Merged at revision: 325
Proposed branch: lp:~akopytov/percona-xtrabackup/bug809073-1.7
Merge into: lp:percona-xtrabackup/2.0
Diff against target: 46 lines (+4/-4)
3 files modified
doc/source/innobackupex/how_innobackupex_works.rst (+1/-1)
doc/source/innobackupex/innobackupex_option_reference.rst (+1/-1)
innobackupex (+2/-2)
To merge this branch: bzr merge lp:~akopytov/percona-xtrabackup/bug809073-1.7
Reviewer Review Type Date Requested Status
Stewart Smith (community) 2011-10-21 Approve on 2011-10-24
Review via email: mp+80092@code.launchpad.net
To post a comment you must log in.
Stewart Smith (stewart) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'doc/source/innobackupex/how_innobackupex_works.rst'
2--- doc/source/innobackupex/how_innobackupex_works.rst 2011-07-28 05:29:04 +0000
3+++ doc/source/innobackupex/how_innobackupex_works.rst 2011-10-21 17:52:17 +0000
4@@ -17,7 +17,7 @@
5
6 By default, it starts :program:`xtrabackup` with the :option:`--suspend-at-end` option, and lets it copy the InnoDB data files. When :program:`xtrabackup` finishes that, :program:`innobackupex` sees it create the :file:`xtrabackup_suspended` file and executes ``FLUSH TABLES WITH READ LOCK``. Then it begins copying the rest of the files.
7
8-If the :option:`--ibbackup-binary` is not supplied, |innobackupex| will try to detect it: if the :file:`xtrabackup_binary` file exists on the backup directory, it reads from it which binary of |xtrabackup| will be used. Otherwise, it will try to connect to the database server in order to determine it. If the connection can't be established, |xtrabackup| will fail and you must specify it (see :ref:`ibk-right-binary`).
9+If the :option:`--ibbackup` is not supplied, |innobackupex| will try to detect it: if the :file:`xtrabackup_binary` file exists on the backup directory, it reads from it which binary of |xtrabackup| will be used. Otherwise, it will try to connect to the database server in order to determine it. If the connection can't be established, |xtrabackup| will fail and you must specify it (see :ref:`ibk-right-binary`).
10
11 When the binary is determined, the connection to the database server is checked. This done by connecting, issuing a query, and closing the connection. If everything goes well, the binary is started as a child process.
12
13
14=== modified file 'doc/source/innobackupex/innobackupex_option_reference.rst'
15--- doc/source/innobackupex/innobackupex_option_reference.rst 2011-07-07 05:32:50 +0000
16+++ doc/source/innobackupex/innobackupex_option_reference.rst 2011-10-21 17:52:17 +0000
17@@ -90,7 +90,7 @@
18
19 Use this option to disable table lock with ``FLUSH TABLES WITH READ LOCK``. Use it only if ALL your tables are InnoDB and you **DO NOT CARE** about the binary log position of the backup.
20
21-.. option:: --ibbackup-binary = 'autodetect'
22+.. option:: --ibbackup = 'autodetect'
23
24 This option accepts a string argument that specifies which xtrabackup binary should be used. The string should be the command used to run *XtraBackup*. The option can be useful if the :program:`xtrabackup` binary is not in your search path or working directory and the database server is not accessible at the moment. If this option is not specified, :program:`innobackupex` attempts to determine the binary to use automatically. By default, :program:`xtrabackup` is the command used. When option :option:`--apply-log` is specified, the binary is used whose name is in the file :file:`xtrabackup_binary` in the backup directory, if that file exists, or will attempt to autodetect it. However, if :option:`--copy-back` is selected, :program:`xtrabackup` is used unless other is specified.
25
26
27=== modified file 'innobackupex'
28--- innobackupex 2011-10-21 13:53:48 +0000
29+++ innobackupex 2011-10-21 17:52:17 +0000
30@@ -2376,7 +2376,7 @@
31
32 innobackupex [--compress[=LEVEL]] [--include=REGEXP] [--user=NAME]
33 [--password=WORD] [--port=PORT] [--socket=SOCKET]
34- [--no-timestamp] [--ibbackup-binary=IBBACKUP-BINARY]
35+ [--no-timestamp] [--ibbackup=IBBACKUP-BINARY]
36 [--slave-info] [--stream=tar] [--force-tar]
37 [--scpopt=OPTIONS-FOR-SCP] [--defaults-file=MY.CNF]
38 [--databases=LIST] [--remote-host=HOSTNAME] [--no-lock]
39@@ -2464,7 +2464,7 @@
40
41 This option specifies the host to use when connecting to the database server with TCP/IP. The option accepts a string argument. It is passed to the mysql child process without alteration. See mysql --help for details.
42
43-=item --ibbackup-binary=IBBACKUP-BINARY
44+=item --ibbackup=IBBACKUP-BINARY
45
46 This option specifies which xtrabackup binary should be used. The option accepts a string argument. IBBACKUP-BINARY should be the command used to run XtraBackup. The option can be useful if the xtrabackup binary is not in your search path or working directory. If this option is not specified, innobackupex attempts to determine the binary to use automatically. By default, "xtrabackup" is the command used. However, when option --copy-back is specified, "xtrabackup_51" is the command used. And when option --apply-log is specified, the binary is used whose name is in the file "xtrabackup_binary" in the backup directory, if that file exists.
47

Subscribers

People subscribed via source and target branches