lp:~akopytov/percona-xtrabackup/bug713267-1.6

Created by Alexey Kopytov on 2012-05-28 and last modified on 2012-05-28
Get this branch:
bzr branch lp:~akopytov/percona-xtrabackup/bug713267-1.6
Only Alexey Kopytov can upload to this branch. If you are Alexey Kopytov please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Recent revisions

340. By Alexey Kopytov on 2012-05-28

Bug #713267: xtrabackup binary leaks file descriptors on --backup

The problem was that the xtrabackup_copy_datafile() called
fil_space_get_zip_size() with the only purpose to determine the
compressed page size for a tablespace. That function opens the tablespace
file to read its flags. But xtrabackup never closed that file, which was
the reason for the file descriptor leak.

Since we already have a file descriptor for the tablespace to be copied,
the bug was fixed duplicating a part of fil_node_open_file() in a
separate function that reads flags from a given tablespace file and then
converts them to the page size. The existing file descriptor is reused
this way, so no leak occurs.

339. By Alexey Kopytov on 2012-05-22

Bug #1002688: innobackupex incremental apply-log copies to wrong
directory

The problem was that the copy_dir_recursively() routine relied on both
the source path and the target one to be in the canonical format,
i.e. not having any trailing slashes. However, when copying files after
merging an incremental backup to the full backup directory, the target
path (i.e. the full backup directory) was always in the canonical
format, because innobackupex calls File::Spec->rel2abs() on it in
check_args(), but the source path (i.e. the --incremental-directory
value) might not be in the canonical format in case the user specified
it with a trailing slash.

Fixed by canonizing both source and the target directories in
copy_dir_recursively() so it does not rely on the arguments format.

338. By Stewart Smith on 2012-05-18

merge fix for Bug #983685: innodb_data_file_path is not written to backup-my.cnf

335. By Stewart Smith on 2012-04-04

fix release date for 1.6.4

334. By Stewart Smith on 2012-04-04

merge 1.6.6 release notes

332. By Stewart Smith on 2012-03-27

merge bug fix for bug733651 that we somehow previously missed, this fixes my.cnf options such as fast-checksum for backup-my.cnf

331. By Stewart Smith on 2012-03-26

merge deprecation warning for --remote-host, updating version it to be removed in to 2.1

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:percona-xtrabackup/2.1
This branch contains Public information 
Everyone can see this information.

Subscribers