Merge lp:~akopytov/percona-xtrabackup/bug514068-1.6 into lp:percona-xtrabackup/1.6

[Alexey Kopytov]

Fixes for bug #514068 and sporadic failures in Jenkins.

[Alexey Kopytov (akopytov)]

http://jenkins.percona.com/view/Percona%20Xtrabackup/job/percona-xtrabackup-1.6-param/81/

[Stewart Smith (stewart)]

review: Approve

=== modified file 'innobackupex'
--- innobackupex	2011-12-02 08:36:03 +0000
+++ innobackupex	2011-12-08 09:19:24 +0000
@@ -12,7 +12,6 @@
 use Pod::Usage qw(pod2usage);
 use POSIX "strftime";
 use POSIX ":sys_wait_h";
-# use POSIX "tmpnam";
 use FileHandle;
 use File::Basename;
 use File::Temp;
@@ -235,10 +234,10 @@
 	else {
 		if( $option_ibbackup_binary eq "autodetect" ){
 			# Try to connect MySQL and get the version
-			print "option_ibbackup_binary is autodetect, trying to connect to MySQL\n";
+			print STDERR "option_ibbackup_binary is autodetect, trying to connect to MySQL\n";
 			my $options = get_mysql_options();
 			$mysql_pid = open(*MYSQL_WRITER, "| mysql $options >$mysql_stdout 2>$mysql_stderr ");
-			print "Connected to MySQL with pid $mysql_pid\n";
+			print STDERR "Connected to MySQL with pid $mysql_pid\n";
 			sleep 1;
 			if ($mysql_pid && $mysql_pid == waitpid($mysql_pid, &WNOHANG)) {
 				my $reason = `cat $mysql_stderr`;
@@ -248,7 +247,7 @@
 				}
 			else{
 				mysql_close();
-				print "Connected successfully\n";
+				print STDERR "Connected successfully\n";
 				$option_ibbackup_binary = set_xtrabackup_version();
 				}
 			}
@@ -996,6 +995,7 @@
 # Check that the server is responding to queries
 #
 sub mysql_ping {
+    my $alarm_handler = shift;
     my $mysql_pid_copy = $mysql_pid;
 
     # send a dummy query to mysql child process
@@ -1005,6 +1005,12 @@
     print MYSQL_WRITER "select '$hello_message';\n" 
         or Die "Connection to mysql child process failed: $!";
 
+    # Don't check server's response if running in a signal handler
+    # because that breaks system() calls
+    if ($alarm_handler)
+    {
+	return 0;
+    }
     # wait for reply
     eval {
         local $SIG{ALRM} = sub { die "alarm clock restart" };
@@ -1040,7 +1046,7 @@
 # SIGALRM handler which sends a keepalive query to the server
 #
 sub catch_sigalrm {
-  mysql_ping();
+  mysql_ping(1);
   # Reschedule SIGALRM
   alarm $mysql_keep_alive;
 }
@@ -1077,7 +1083,7 @@
     $now = current_time();
     print STDERR "$now  $prefix Connected to database with mysql child process (pid=$mysql_pid)\n";
 
-    mysql_ping();
+    mysql_ping(0);
 
     start_keepalives();
 }
@@ -1097,7 +1103,7 @@
 
     $current_mysql_request = $request;
     print MYSQL_WRITER "$request\n";
-    mysql_ping();
+    mysql_ping(0);
     $current_mysql_request = '';
 
     start_keepalives();
@@ -1700,10 +1706,6 @@
             } else {
                 $incremental_basedir = File::Spec->catfile($backup_root, $inc_dir);
             }
-
-            #print STDERR "--incremental_basedir=$incremental_basedir\n";
-            #print STDERR "incremental backup is not supported for now.\n";
-            #exit(1);
         }
     } else {
         # get backup directory

=== added file 'test/t/bug514068.sh'
--- test/t/bug514068.sh	1970-01-01 00:00:00 +0000
+++ test/t/bug514068.sh	2011-12-08 09:19:24 +0000
@@ -0,0 +1,30 @@
+##################################################################
+# Bug #514068: Output to STDOUT and STDERR is not conventional	 #
+# Bug #741021: xtrabackup --prepare prints a few lines to stdout #
+##################################################################
+
+. inc/common.sh
+
+init
+run_mysqld
+
+innobackupex  --no-timestamp $topdir/backup >$topdir/stdout 2>$topdir/stderr
+
+stop_mysqld
+# Remove datadir
+rm -r $mysql_datadir
+
+# Restore sakila
+vlog "Applying log"
+innobackupex --apply-log $topdir/backup >>$topdir/stdout 2>>$topdir/stderr
+
+vlog "Restoring MySQL datadir"
+mkdir -p $mysql_datadir
+innobackupex --copy-back $topdir/backup >>$topdir/stdout 2>>$topdir/stderr
+
+if [ "`wc -l $topdir/stdout`" -gt 0 ]
+then
+    vlog "Got the following output on stdout:"
+    cat $topdir/stdout
+    exit -1
+fi

=== modified file 'test/t/bug817132.sh'
--- test/t/bug817132.sh	2011-09-12 10:05:36 +0000
+++ test/t/bug817132.sh	2011-12-08 09:19:24 +0000
@@ -18,7 +18,7 @@
 load_dbase_data sakila
 
 mkdir -p $topdir/backup
-innobackupex  $topdir/backup > $OUTFILE 2>&1 
+innobackupex  $topdir/backup
 backup_dir=`grep "innobackupex: Backup created in directory" $OUTFILE | awk -F\' '{ print $2}'`
 vlog "Backup created in directory $backup_dir"
 
@@ -28,14 +28,14 @@
 
 # Restore sakila
 vlog "Applying log"
-innobackupex --apply-log $backup_dir >> $OUTFILE 2>&1
+innobackupex --apply-log $backup_dir
 vlog "Restoring MySQL datadir"
 mkdir -p $mysql_datadir
 
 # The following would fail before #817132 was fixed.
 # Cannot use innobackupex here, because that would specify
 # --ibbackup explicitly (see $IB_ARGS).
-run_cmd $IB_BIN --defaults-file=$topdir/my.cnf --user=root --socket=$mysql_socket --copy-back $backup_dir >> $OUTFILE 2>&1
+run_cmd $IB_BIN --defaults-file=$topdir/my.cnf --user=root --socket=$mysql_socket --copy-back $backup_dir
 
 run_mysqld
 # Check sakila

=== modified file 'test/t/ib_csm_csv.sh'
--- test/t/ib_csm_csv.sh	2011-09-14 12:48:27 +0000
+++ test/t/ib_csm_csv.sh	2011-12-08 09:19:24 +0000
@@ -20,7 +20,7 @@
 mkdir -p $topdir/backup
 
 vlog "Starting backup"
-innobackupex $topdir/backup > $OUTFILE 2>&1 
+innobackupex $topdir/backup
 full_backup_dir=`grep "innobackupex: Backup created in directory" $OUTFILE | awk -F\' '{print $2}'`
 vlog "Full backup done to directory $full_backup_dir"
 
@@ -30,10 +30,10 @@
 
 vlog "Preparing backup"
 # Prepare backup
-echo "###########" >> $OUTFILE
-echo "# PREPARE #" >> $OUTFILE
-echo "###########" >> $OUTFILE
-innobackupex --apply-log $full_backup_dir >> $OUTFILE 2>&1 
+vlog "###########"
+vlog "# PREPARE #"
+vlog "###########"
+innobackupex --apply-log $full_backup_dir
 vlog "Data prepared for restore"
 
 # Destroying mysql data
@@ -43,10 +43,10 @@
 
 # Restore backup
 vlog "Copying files"
-echo "###########" >> $OUTFILE
-echo "# RESTORE #" >> $OUTFILE
-echo "###########" >> $OUTFILE
-innobackupex --copy-back $full_backup_dir >> $OUTFILE 2>&1
+vlog "###########"
+vlog "# RESTORE #"
+vlog "###########"
+innobackupex --copy-back $full_backup_dir
 vlog "Data restored"
 
 run_mysqld --innodb_file_per_table

=== modified file 'test/t/ib_specialchar.sh'
--- test/t/ib_specialchar.sh	2011-06-10 06:11:56 +0000
+++ test/t/ib_specialchar.sh	2011-12-08 09:19:24 +0000
@@ -14,7 +14,7 @@
 vlog "mysql password has been changed to contain special char"
 
 vlog "Starting innobackupex wrapper"
-innobackupex --password='$PASSWD' $topdir/backup > $OUTFILE 2>&1 
+innobackupex --password='$PASSWD' $topdir/backup
 backup_dir=`grep "innobackupex: Backup created in directory" $OUTFILE | awk -F\' '{ print $2}'`
 
 run_cmd ${MYSQLADMIN} ${MYSQL_ARGS} -p'$PASSWD' password ''
@@ -26,17 +26,17 @@
 rm -r $mysql_datadir
 # Restore sakila
 vlog "Applying log"
-echo "###########" >> $OUTFILE
-echo "# PREPARE #" >> $OUTFILE
-echo "###########" >> $OUTFILE
-innobackupex --apply-log $backup_dir >> $OUTFILE 2>&1
+vlog "###########"
+vlog "# PREPARE #"
+vlog "###########"
+innobackupex --apply-log $backup_dir
 vlog "Restoring MySQL datadir"
 mkdir -p $mysql_datadir
 vlog "Performing copyback"
-echo "###########" >> $OUTFILE
-echo "# PREPARE #" >> $OUTFILE
-echo "###########" >> $OUTFILE
-innobackupex --copy-back $backup_dir >> $OUTFILE 2>&1
+vlog "###########"
+vlog "# PREPARE #"
+vlog "###########"
+innobackupex --copy-back $backup_dir
 
 vlog "Starting database server"
 # using --skip-grant-tables to override root password restored from backup

=== modified file 'test/t/xb_basic.sh'
--- test/t/xb_basic.sh	2011-06-10 06:11:56 +0000
+++ test/t/xb_basic.sh	2011-12-08 09:19:24 +0000
@@ -6,7 +6,7 @@
 load_dbase_data sakila
 
 mkdir -p $topdir/backup
-innobackupex  $topdir/backup > $OUTFILE 2>&1 
+innobackupex  $topdir/backup
 backup_dir=`grep "innobackupex: Backup created in directory" $OUTFILE | awk -F\' '{ print $2}'`
 vlog "Backup created in directory $backup_dir"
 
@@ -16,16 +16,16 @@
 #init_mysql_dir
 # Restore sakila
 vlog "Applying log"
-echo "###########" >> $OUTFILE
-echo "# PREPARE #" >> $OUTFILE
-echo "###########" >> $OUTFILE
-innobackupex --apply-log $backup_dir >> $OUTFILE 2>&1
+vlog "###########"
+vlog "# PREPARE #"
+vlog "###########"
+innobackupex --apply-log $backup_dir
 vlog "Restoring MySQL datadir"
 mkdir -p $mysql_datadir
-echo "###########" >> $OUTFILE
-echo "# RESTORE #" >> $OUTFILE
-echo "###########" >> $OUTFILE
-innobackupex --copy-back $backup_dir >> $OUTFILE 2>&1
+vlog "###########"
+vlog "# RESTORE #"
+vlog "###########"
+innobackupex --copy-back $backup_dir
 
 run_mysqld
 # Check sakila

=== modified file 'test/t/xb_parallel.sh'
--- test/t/xb_parallel.sh	2011-06-10 06:11:56 +0000
+++ test/t/xb_parallel.sh	2011-12-08 09:19:24 +0000
@@ -8,7 +8,7 @@
 # Take backup
 vlog "Creating the backup directory: $topdir/backup"
 mkdir -p $topdir/backup
-innobackupex $topdir/backup --parallel=8 > $OUTFILE 2>&1 
+innobackupex $topdir/backup --parallel=8
 backup_dir=`grep "innobackupex: Backup created in directory" $OUTFILE | awk -F\' '{ print $2}'`
 
 #echo "Backup dir in $backup_dir"
@@ -18,16 +18,16 @@
 rm -r $mysql_datadir
 # Restore sakila
 vlog "Applying log"
-echo "###########" >> $OUTFILE
-echo "# PREPARE #" >> $OUTFILE
-echo "###########" >> $OUTFILE
-innobackupex --apply-log $backup_dir >> $OUTFILE 2>&1
+vlog "###########"
+vlog "# PREPARE #"
+vlog "###########"
+innobackupex --apply-log $backup_dir
 vlog "Restoring MySQL datadir"
 mkdir -p $mysql_datadir
-echo "###########" >> $OUTFILE
-echo "# RESTORE #" >> $OUTFILE
-echo "###########" >> $OUTFILE
-innobackupex --copy-back $backup_dir >> $OUTFILE 2>&1
+vlog "###########"
+vlog "# RESTORE #"
+vlog "###########"
+innobackupex --copy-back $backup_dir
 
 run_mysqld
 # Check sakila

=== modified file 'test/t/xb_stats.sh'
--- test/t/xb_stats.sh	2011-06-10 06:11:56 +0000
+++ test/t/xb_stats.sh	2011-12-08 09:19:24 +0000
@@ -16,7 +16,7 @@
 
 vlog "===> xtrabackup --stats --datadir=$topdir/backup"
 # Cannot use run_cmd here
-if $XB_BIN $XB_ARGS --stats --datadir=$topdir/backup >$OUTFILE 2>&1
+if $XB_BIN $XB_ARGS --stats --datadir=$topdir/backup
 then
     die "xtrabackup --stats was expected to fail, but it did not."
 fi

=== modified file 'test/t/xb_stream.sh'
--- test/t/xb_stream.sh	2011-06-14 13:33:54 +0000
+++ test/t/xb_stream.sh	2011-12-08 09:19:24 +0000
@@ -7,7 +7,7 @@
 
 # Take backup
 mkdir -p $topdir/backup
-innobackupex --stream=tar $topdir/backup > $topdir/backup/out.tar 2> $OUTFILE 
+innobackupex --stream=tar $topdir/backup > $topdir/backup/out.tar
 
 stop_mysqld
 # Remove datadir
@@ -18,15 +18,15 @@
 cd $backup_dir
 $TAR -ixvf out.tar
 cd - >/dev/null 2>&1 
-echo "###########" >> $OUTFILE
-echo "# PREPARE #" >> $OUTFILE
-echo "###########" >> $OUTFILE
-innobackupex --apply-log $backup_dir >> $OUTFILE 2>&1
+vlog "###########"
+vlog "# PREPARE #"
+vlog "###########"
+innobackupex --apply-log $backup_dir
 vlog "Restoring MySQL datadir"
 mkdir -p $mysql_datadir
-echo "###########" >> $OUTFILE
-echo "# RESTORE #" >> $OUTFILE
-echo "###########" >> $OUTFILE
+vlog "###########"
+vlog "# RESTORE #"
+vlog "###########"
 innobackupex  --copy-back $backup_dir
 
 run_mysqld

=== modified file 'xtrabackup.c'
--- xtrabackup.c	2011-11-28 12:43:46 +0000
+++ xtrabackup.c	2011-12-08 09:19:24 +0000
@@ -6036,10 +6036,17 @@
 	if ((!xtrabackup_prepare) && (strcmp(mysql_data_home, "./") == 0)) {
 		if (!xtrabackup_print_param)
 			usage();
-		printf("\nxtrabackup: Error: Please set parameter 'datadir'\n");
+		fprintf(stderr, "\n"
+		       "xtrabackup: Error: Please set parameter 'datadir'\n");
 		exit(EXIT_FAILURE);
 	}
 
+	/* Redirect stdout to stderr for not doing a streaming backup or dumping
+	configuration for --print-param. */
+	if (!xtrabackup_stream && !xtrabackup_print_param && dup2(2, 1) < 0) {
+		fprintf(stderr, "Failed to redirect standard output.\n");
+	}
+
 	if (xtrabackup_tables) {
 		/* init regexp */
 		char *p, *next;