Merge lp:~akopytov/percona-xtrabackup/bug369913 into lp:percona-xtrabackup/2.2

Proposed by Alexey Kopytov
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 5038
Proposed branch: lp:~akopytov/percona-xtrabackup/bug369913
Merge into: lp:percona-xtrabackup/2.2
Diff against target: 48 lines (+22/-0)
3 files modified
storage/innobase/xtrabackup/innobackupex.pl (+5/-0)
storage/innobase/xtrabackup/src/xtrabackup.cc (+2/-0)
storage/innobase/xtrabackup/test/t/bug369913.sh (+15/-0)
To merge this branch: bzr merge lp:~akopytov/percona-xtrabackup/bug369913
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+239031@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'storage/innobase/xtrabackup/innobackupex.pl'
2--- storage/innobase/xtrabackup/innobackupex.pl 2014-10-08 16:13:58 +0000
3+++ storage/innobase/xtrabackup/innobackupex.pl 2014-10-21 11:07:45 +0000
4@@ -3583,6 +3583,11 @@
5 } else {
6 $run = 'apply-log';
7 }
8+
9+ my $now = current_time();
10+
11+ print STDERR "$now $prefix Starting the $run operation\n\n";
12+
13 print STDERR "IMPORTANT: Please check that the $run run completes successfully.\n";
14 print STDERR " At the end of a successful $run run $innobackup_script\n";
15 print STDERR " prints \"completed OK!\".\n\n";
16
17=== modified file 'storage/innobase/xtrabackup/src/xtrabackup.cc'
18--- storage/innobase/xtrabackup/src/xtrabackup.cc 2014-10-08 18:33:23 +0000
19+++ storage/innobase/xtrabackup/src/xtrabackup.cc 2014-10-21 11:07:45 +0000
20@@ -2643,6 +2643,8 @@
21 srv_undo_tablespaces_init(), because fil_is_user_tablespace_id() *
22 relies on srv_undo_tablespaces_open to be properly initialized */
23
24+ msg("xtrabackup: Generating a list of tablespaces\n");
25+
26 err = fil_load_single_table_tablespaces(xb_check_if_open_tablespace);
27 if (err != DB_SUCCESS) {
28 return(err);
29
30=== added file 'storage/innobase/xtrabackup/test/t/bug369913.sh'
31--- storage/innobase/xtrabackup/test/t/bug369913.sh 1970-01-01 00:00:00 +0000
32+++ storage/innobase/xtrabackup/test/t/bug369913.sh 2014-10-21 11:07:45 +0000
33@@ -0,0 +1,15 @@
34+#############################################################################
35+# Bug #369913: Feature Request: more verbose output during initial table scan
36+#############################################################################
37+
38+start_server
39+
40+innobackupex --no-timestamp $topdir/backup
41+
42+egrep -q \
43+ '[0-9]{6} [0-9]{2}:[0-9]{2}:[0-9]{2} .* Starting the backup operation' \
44+ $OUTFILE \
45+ || die "Could not find the operation start message"
46+
47+grep -q "xtrabackup: Generating a list of tablespaces" $OUTFILE \
48+ || die "Could not find \"Generating a list of tablespaces\" message"

Subscribers

People subscribed via source and target branches

to all changes: