lp:~akopytov/percona-xtrabackup/bug1294782-2.1

Created by Alexey Kopytov and last modified
Get this branch:
bzr branch lp:~akopytov/percona-xtrabackup/bug1294782-2.1
Only Alexey Kopytov can upload to this branch. If you are Alexey Kopytov please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Recent revisions

740. By Alexey Kopytov

Bug #1294782: Innobackupex hangs on fatal error in some cases

The problem was that the code in both innobackupex and xtrabackup, that
was supposed to make sure no child processes are left running in case
innobackupex got killed or failed with an error, relied on the fact the
SIGTERM and SIGINT signals were not blocked by the xtrabackup process
(or any other child processes spawned by innobackupex).

When innobackupex terminates gracefully, it calls kill_child_processes()
to send SIGTERM to its children.

There’s also (Linux-specific) auto-termination logic in xtrabackup for
cases when innobackupex is killed or terminates ungracefully. It worked
as follows: the xtrabackup process called prctl(PR_SET_PDEATHSIG,
SIGINT) on start, so that SIGINT is sent automatically in case the parent
process (innobackupex) dies.

However, both SIGTERM and SIGINT might be blocked by the
process that had invoked innobackupex, for example, by the PXC server
processes doing an SST, in which case they were also blocked by the
xtrabackup process, since the signal mask is inherited by child
processes.

Fixed by replacing SIGTERM in innobackupex and SIGINT in xtrabackup
auto-termination with SIGKILL.

Also removed some ancient code around FTWRL. It has been unnecessary for
a long time, which has been reported in duplicate bug #1311120.

No test case, as it is impossible in Bash to create a signal mask that
would be inherited by child processes. Signal masks created by ‘trap’
are only inherited by built-in commands according to the manual.

737. By Alexey Kopytov

Empty merge from 2.0.

734. By Hrvoje Matijakovic

Fixed bugs: Bug #1269474, Bug #128108 and DOC-84

733. By Hrvoje Matijakovic

- PXB-2.1.8 release notes
- removed the percona-theme from the SCM

732. By Alexey Kopytov

Empty merge from 2.0.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:percona-xtrabackup/2.2
This branch contains Public information 
Everyone can see this information.

Subscribers