Merge lp:~akopytov/percona-xtrabackup/bug1285166-2.1 into lp:percona-xtrabackup/2.1

[Alexey Kopytov]

    Bug #1285166: Disable "binary version" functionality in VersionCheck.

    Removed code implementing the “binary” version functionality.

http://jenkins.percona.com/view/PXB%202.1/job/percona-xtrabackup-2.1-param/552/

[Sergei Glushchenko (sergei.glushchenko)]

Approve

review: Approve (g2)

=== modified file 'innobackupex.pl'
--- innobackupex.pl	2014-01-22 17:09:37 +0000
+++ innobackupex.pl	2014-02-28 06:02:11 +0000
@@ -1301,7 +1301,6 @@
    perl_version        => \&get_perl_version,
    perl_module_version => \&get_perl_module_version,
    mysql_variable      => \&get_mysql_variable,
-   bin_version         => \&get_bin_version,
 );
 
 sub valid_item {
@@ -1484,25 +1483,6 @@
    return \%version_for;
 }
 
-sub get_bin_version {
-   my (%args) = @_;
-   my $item = $args{item};
-   my $cmd  = $item->{item};
-   return unless $cmd;
-
-   my $sanitized_command = File::Basename::basename($cmd);
-   PTDEBUG && _d('cmd:', $cmd, 'sanitized:', $sanitized_command);
-   return if $sanitized_command !~ /\A[a-zA-Z0-9_-]+\z/;
-
-   my $output = `$sanitized_command --version 2>&1`;
-   PTDEBUG && _d('output:', $output);
-
-   my ($version) = $output =~ /v?([0-9]+\.[0-9]+(?:\.[\w-]+)?)/;
-
-   PTDEBUG && _d('Version for', $sanitized_command, '=', $version);
-   return $version;
-}
-
 sub _d {
    my ($package, undef, $line) = caller 0;
    @_ = map { (my $temp = $_) =~ s/\n/\n# /g; $temp; }