Merge lp:~akopytov/percona-xtrabackup/bug1271501-2.2 into lp:percona-xtrabackup/2.2

Proposed by Alexey Kopytov
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 4935
Proposed branch: lp:~akopytov/percona-xtrabackup/bug1271501-2.2
Merge into: lp:percona-xtrabackup/2.2
Diff against target: 81 lines (+15/-8)
4 files modified
storage/innobase/xtrabackup/innobackupex.pl (+3/-3)
storage/innobase/xtrabackup/test/bootstrap.sh (+2/-2)
storage/innobase/xtrabackup/test/t/bug1037379.sh (+3/-0)
storage/innobase/xtrabackup/test/t/bug1250375.sh (+7/-3)
To merge this branch: bzr merge lp:~akopytov/percona-xtrabackup/bug1271501-2.2
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+203049@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'storage/innobase/xtrabackup/innobackupex.pl'
2--- storage/innobase/xtrabackup/innobackupex.pl 2014-01-16 14:23:32 +0000
3+++ storage/innobase/xtrabackup/innobackupex.pl 2014-01-24 12:11:56 +0000
4@@ -3181,8 +3181,8 @@
5 die "Failed to get master binlog coordinates from SHOW MASTER STATUS";
6 }
7
8- backup_file("$log_bin_dir", "$log_bin_file",
9- "$backup_dir/$log_bin_dir/$log_bin_file")
10+ backup_file("$log_bin_dir", "$log_bin_file",
11+ "$backup_dir/$log_bin_file");
12 }
13 }
14
15@@ -3439,8 +3439,8 @@
16 if ($option_kill_long_queries_timeout) {
17 stop_query_killer();
18 }
19+ write_galera_info($con) if $option_galera_info;
20 write_binlog_info($con);
21- write_galera_info($con) if $option_galera_info;
22 $now = current_time();
23 print STDERR "$now $prefix All tables locked and flushed to disk\n";
24 }
25
26=== modified file 'storage/innobase/xtrabackup/test/bootstrap.sh'
27--- storage/innobase/xtrabackup/test/bootstrap.sh 2014-01-16 08:56:59 +0000
28+++ storage/innobase/xtrabackup/test/bootstrap.sh 2014-01-24 12:11:56 +0000
29@@ -90,8 +90,8 @@
30 then
31 # PS 5.6.11-rc60.3 tarballs are affected by LP bug #1172916
32 # and thus unusable on anything but CentOS
33- url="http://www.percona.com/downloads/TESTING/Percona-Server-56/Percona-Server-5.6.10-alpha60.2/release-5.6.10-60.2/318/binary/linux/$arch"
34- tarball="Percona-Server-5.6.10-alpha60.2-318.Linux.$arch.tar.gz"
35+ url="http://www.percona.com/downloads/TESTING/Percona-Server-56/Percona-Server-5.6.10-alpha60.2/binary/linux/$arch"
36+ tarball="Percona-Server-5.6.10-alpha60.2-324.Linux.$arch.tar.gz"
37 else
38 url="http://s3.amazonaws.com/percona.com/downloads/community"
39 tarball="Percona-Server-5.6.14-rel62.0-483.Linux.$arch.tar.gz"
40
41=== modified file 'storage/innobase/xtrabackup/test/t/bug1037379.sh'
42--- storage/innobase/xtrabackup/test/t/bug1037379.sh 2014-01-12 16:55:59 +0000
43+++ storage/innobase/xtrabackup/test/t/bug1037379.sh 2014-01-24 12:11:56 +0000
44@@ -4,6 +4,9 @@
45 # Bug #887803: innobackupex --safe-slave-backup-timeout option doesn't work
46 ################################################################################
47
48+# Galera supports only RBR which does not replicated temp. tables
49+is_galera && skip_test "Requires a server without Galera support"
50+
51 . inc/common.sh
52
53 ################################################################################
54
55=== modified file 'storage/innobase/xtrabackup/test/t/bug1250375.sh'
56--- storage/innobase/xtrabackup/test/t/bug1250375.sh 2014-01-16 14:22:21 +0000
57+++ storage/innobase/xtrabackup/test/t/bug1250375.sh 2014-01-24 12:11:56 +0000
58@@ -25,6 +25,12 @@
59
60 start_server
61
62+# Load some data so we have a non-empty Executed_Gtid_Set
63+$MYSQL $MYSQL_ARGS test <<EOF
64+CREATE TABLE t1(a INT) ENGINE=InnoDB;
65+INSERT INTO t1 VALUES (1), (2), (3);
66+EOF
67+
68 innobackupex --no-timestamp --galera-info $topdir/backup
69 backup_dir=$topdir/backup
70 vlog "Backup created in directory $backup_dir"
71@@ -41,9 +47,7 @@
72 count=$((count+1))
73 done <<< "`run_cmd $MYSQL $MYSQL_ARGS -Nse 'SHOW MASTER STATUS\G' mysql`"
74
75-stop_server
76-
77-if [ -f "$backup_dir/$master_file" ]
78+if [ ! -f "$backup_dir/$master_file" ]
79 then
80 vlog "Could not find bin-log file in backup set, expecting to find $master_file"
81 exit 1

Subscribers

People subscribed via source and target branches

to all changes: