Merge lp:~akopytov/percona-xtrabackup/bug1206363 into lp:percona-xtrabackup/2.1

Proposed by Alexey Kopytov
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 647
Proposed branch: lp:~akopytov/percona-xtrabackup/bug1206363
Merge into: lp:percona-xtrabackup/2.1
Diff against target: 35 lines (+20/-0)
2 files modified
src/xtrabackup.cc (+6/-0)
test/t/bug1206363.sh (+14/-0)
To merge this branch: bzr merge lp:~akopytov/percona-xtrabackup/bug1206363
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+177515@code.launchpad.net

Description of the change

  Bug #1206363: xtrabackup: Unrecognized value O_DIRECT_NO_FSYNC for
                innodb_flush_method

  Added O_DIRECT_NO_FSYNC to the list of supported innodb_flush_method in
  xtrabackup_56.

To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) wrote :
Revision history for this message
Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/xtrabackup.cc'
2--- src/xtrabackup.cc 2013-07-27 10:57:55 +0000
3+++ src/xtrabackup.cc 2013-07-30 07:19:28 +0000
4@@ -2969,6 +2969,12 @@
5 srv_unix_file_flush_method = SRV_UNIX_ALL_O_DIRECT;
6 msg("xtrabackup: using ALL_O_DIRECT\n");
7 #endif
8+#if MYSQL_VERSION_ID > 50600
9+ } else if (0 == ut_strcmp(srv_file_flush_method_str,
10+ "O_DIRECT_NO_FSYNC")) {
11+ srv_unix_file_flush_method = SRV_UNIX_O_DIRECT_NO_FSYNC;
12+ msg("xtrabackup: using O_DIRECT_NO_FSYNC\n");
13+#endif
14 } else {
15 msg("xtrabackup: Unrecognized value %s for "
16 "innodb_flush_method\n", srv_file_flush_method_str);
17
18=== added file 'test/t/bug1206363.sh'
19--- test/t/bug1206363.sh 1970-01-01 00:00:00 +0000
20+++ test/t/bug1206363.sh 2013-07-30 07:19:28 +0000
21@@ -0,0 +1,14 @@
22+########################################################################
23+# Bug #1206363: xtrabackup: Unrecognized value O_DIRECT_NO_FSYNC for
24+# innodb_flush_method
25+########################################################################
26+
27+require_server_version_higher_than 5.6.6
28+
29+MYSQLD_EXTRA_MY_CNF_OPTS="
30+innodb_flush_method=O_DIRECT_NO_FSYNC
31+"
32+
33+start_server
34+
35+innobackupex --no-timestamp $topdir/backup

Subscribers

People subscribed via source and target branches

to all changes: