Merge lp:~akopytov/percona-xtrabackup/bug1166888-2.1 into lp:percona-xtrabackup/2.1

[Alexey Kopytov]

  Bug #1166888: XtraBackup segfaults after period of time

  The problem was that that the log copying thread did not call
  my_thread_init() which resulted in a crash as soon as any mysys function
  tried to access my_thread_var.

  Fixed by calling my_thread_init() and my_thread_end() when necessary.

http://jenkins.percona.com/view/XtraBackup/job/percona-xtrabackup-2.1-param/247/

[Laurynas Biveinis (laurynas-biveinis)]

This results in double my_thread_init() call:

log_copying_thread(
 void* arg __attribute__((unused)))
{
 ulint counter = 0;

 /*
   Initialize mysys thread-specific memory so we can
   use mysys functions in this thread.
 */
 my_thread_init();

 ut_a(dst_log_file != NULL);

 /*
   Initialize mysys thread-specific memory so we can
   use mysys functions in this thread.
 */
 my_thread_init();

Also it's not an automerge, but just a merge.

review: Needs Fixing

[Alexey Kopytov (akopytov)]

Right, the bug is Invalid for 2.1. Will null-merge. But just or the record, it _was_ an automerge :)

[lp:~akopytov/percona-xtrabackup/bug1166888-2.1]

535. By Alexey Kopytov on 2013-04-15

Null merge from 2.0.

[Alexey Kopytov (akopytov)]

Self-approving the null merge.

review: Approve

[Laurynas Biveinis (laurynas-biveinis)]

ah, so my_thread_end() bit disappearing from the diff was an automerge then, I see :)