Merge lp:~akopytov/percona-xtrabackup/bug1166888-2.1 into lp:percona-xtrabackup/2.1

Proposed by Alexey Kopytov on 2013-04-11
Status: Merged
Approved by: Alexey Kopytov on 2013-04-15
Approved revision: 535
Merged at revision: 540
Proposed branch: lp:~akopytov/percona-xtrabackup/bug1166888-2.1
Merge into: lp:percona-xtrabackup/2.1
Diff against target: 0 lines
To merge this branch: bzr merge lp:~akopytov/percona-xtrabackup/bug1166888-2.1
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve on 2013-04-15
Laurynas Biveinis (community) Needs Fixing on 2013-04-15
Review via email: mp+158417@code.launchpad.net

Description of the change

  Bug #1166888: XtraBackup segfaults after period of time

  The problem was that that the log copying thread did not call
  my_thread_init() which resulted in a crash as soon as any mysys function
  tried to access my_thread_var.

  Fixed by calling my_thread_init() and my_thread_end() when necessary.

http://jenkins.percona.com/view/XtraBackup/job/percona-xtrabackup-2.1-param/247/

To post a comment you must log in.

This results in double my_thread_init() call:

log_copying_thread(
 void* arg __attribute__((unused)))
{
 ulint counter = 0;

 /*
   Initialize mysys thread-specific memory so we can
   use mysys functions in this thread.
 */
 my_thread_init();

 ut_a(dst_log_file != NULL);

 /*
   Initialize mysys thread-specific memory so we can
   use mysys functions in this thread.
 */
 my_thread_init();

Also it's not an automerge, but just a merge.

review: Needs Fixing
Alexey Kopytov (akopytov) wrote :

Right, the bug is Invalid for 2.1. Will null-merge. But just or the record, it _was_ an automerge :)

535. By Alexey Kopytov on 2013-04-15

Null merge from 2.0.

Alexey Kopytov (akopytov) wrote :

Self-approving the null merge.

review: Approve

ah, so my_thread_end() bit disappearing from the diff was an automerge then, I see :)

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to all changes: