Merge lp:~akopytov/percona-xtrabackup/bug1153334-2.1 into lp:percona-xtrabackup/2.1

Proposed by Alexey Kopytov
Status: Merged
Approved by: Sergei Glushchenko
Approved revision: no longer in the source branch.
Merged at revision: 515
Proposed branch: lp:~akopytov/percona-xtrabackup/bug1153334-2.1
Merge into: lp:percona-xtrabackup/2.1
Diff against target: 36 lines (+18/-1)
1 file modified
test/testrun.sh (+18/-1)
To merge this branch: bzr merge lp:~akopytov/percona-xtrabackup/bug1153334-2.1
Reviewer Review Type Date Requested Status
Sergei Glushchenko (community) g2 Approve
Review via email: mp+152612@code.launchpad.net

Description of the change

    Bug #1153334: Failing CentOS5-32 builds in Jenkins

    The problem was SELinux preventing relocations in
    ha_innodb_plugin.so.0.0.0 on Centos5-32 slaves in Jenkins. As a result,
    all tests failed in the innodb51 + centos5-32 build configuration.

    Fixed by adding a workaround to testrun.sh so that the corresponding
    library is marked to allow relocations.

http://jenkins.percona.com/view/XtraBackup/job/percona-xtrabackup-2.1-param/205/

To post a comment you must log in.
Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

Approve

review: Approve (g2)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'test/testrun.sh'
2--- test/testrun.sh 2013-01-14 11:02:59 +0000
3+++ test/testrun.sh 2013-03-11 05:40:40 +0000
4@@ -92,6 +92,21 @@
5 MYSQL_INSTALL_DB PATH LD_LIBRARY_PATH DYLD_LIBRARY_PATH MYSQLDUMP
6 }
7
8+
9+# Fix innodb51 test failures on Centos5-32 Jenkins slaves due to SELinux
10+# preventing shared symbol relocations in ha_innodb_plugin.so.0.0.0
11+function fix_selinux()
12+{
13+ if which lsb_release &>/dev/null && \
14+ lsb_release -d | grep CentOS &>/dev/null && \
15+ lsb_release -r | egrep '5.[0-9]' &>/dev/null && \
16+ which chcon &>/dev/null
17+ then
18+ chcon -t textrel_shlib_t $MYSQL_BASEDIR/lib/plugin/ha_innodb_plugin.so.0.0.0
19+ fi
20+}
21+
22+
23 function get_version_info()
24 {
25 MYSQLD_EXTRA_ARGS=
26@@ -109,7 +124,9 @@
27 XB_BIN="xtrabackup_51";;
28 "innodb51" )
29 XB_BIN="xtrabackup_plugin"
30- MYSQLD_EXTRA_ARGS="--ignore-builtin-innodb --plugin-load=innodb=ha_innodb_plugin.so";;
31+ MYSQLD_EXTRA_ARGS="--ignore-builtin-innodb --plugin-load=innodb=ha_innodb_plugin.so"
32+ fix_selinux
33+ ;;
34 "innodb55" )
35 XB_BIN="xtrabackup_innodb55";;
36 "xtradb51" | "mariadb51" | "mariadb52" | "mariadb53")

Subscribers

People subscribed via source and target branches

to all changes: