Merge lp:~akopytov/percona-xtrabackup/bug1096584-2.0 into lp:percona-xtrabackup/2.0

[Alexey Kopytov]

    Bug #1096584: Test suite may kill unrelated processes due to stale PID
                  files

    PIDs are stored in $TEST_BASEDIR/mysqld<id>.pid. When a leftover server
    instance was killed with SIGKILL, the pid file was left in
    $TEST_BASEDIR. Normally the next test would overwrite the PID
    file. However, there might be cases when a test case starts two server
    instances (i.e. there are mysql1.pid and mysqld2.pid), and the next one
    starts only one (i.e. it only overwrites mysqld1.pid). So the next test
    will attempt to kill the same PID stored in mysqld2.pid once again.

    Fixed by removing PID files after killing the corresponding server
    instance.

http://jenkins.percona.com/job/percona-xtrabackup-2.0-param/322/

[Stewart Smith (stewart)]

review: Approve

=== modified file 'test/inc/common.sh'
--- test/inc/common.sh	2012-11-12 05:06:16 +0000
+++ test/inc/common.sh	2013-01-07 05:56:21 +0000
@@ -65,6 +65,7 @@
 	then
 	    vlog "Found a leftover mysqld processes with PID `cat $file`, stopping it"
 	    kill -9 `cat $file` 2>/dev/null || true
+	    rm -f $file
 	fi
     done
 }