Merge lp:~akopytov/percona-xtrabackup/bug1087219-2.0 into lp:percona-xtrabackup/2.0

Proposed by Alexey Kopytov on 2013-03-07
Status: Merged
Approved by: Sergei Glushchenko on 2013-03-11
Approved revision: 505
Merged at revision: 511
Proposed branch: lp:~akopytov/percona-xtrabackup/bug1087219-2.0
Merge into: lp:percona-xtrabackup/2.0
Diff against target: 17 lines (+8/-0)
1 file modified
innobackupex (+8/-0)
To merge this branch: bzr merge lp:~akopytov/percona-xtrabackup/bug1087219-2.0
Reviewer Review Type Date Requested Status
Sergei Glushchenko g2 2013-03-07 Approve on 2013-03-11
Review via email: mp+152111@code.launchpad.net

Description of the change

  Bug #1087219: innobackupex should have better error reporting for
                unrecognized server versions

  Now innobackupex prints the following error message when encountering
  an unrecognizable server version:

  "
  innobackupex: Error: Unsupported server version: <server version> (InnoDB version: <innodb_version>). Please report a bug at https://bugs.launchpad.net/percona-xtrabackup
  "

http://jenkins.percona.com/view/XtraBackup/job/percona-xtrabackup-2.0-param/360/

To post a comment you must log in.

Approve

review: Approve (g2)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'innobackupex'
2--- innobackupex 2013-02-04 07:32:47 +0000
3+++ innobackupex 2013-03-07 08:21:26 +0000
4@@ -2739,6 +2739,14 @@
5 $ibbackup_binary = ($win eq 1 ? 'xtrabackup.exe' : 'xtrabackup_55');
6 }
7 mysql_close();
8+
9+if (!$ibbackup_binary) {
10+ Die "Unsupported server version: '$var_version' " .
11+ "(InnoDB version: '$var_innodb_version'). " .
12+ "Please report a bug at ".
13+ "https://bugs.launchpad.net/percona-xtrabackup\n";
14+}
15+
16 return $ibbackup_binary;
17 }
18

Subscribers

People subscribed via source and target branches