Merge lp:~akopytov/percona-xtrabackup/bug1049291-2.1 into lp:percona-xtrabackup/2.1
Status: | Merged |
---|---|
Approved by: | Alexey Kopytov |
Approved revision: | no longer in the source branch. |
Merged at revision: | 700 |
Proposed branch: | lp:~akopytov/percona-xtrabackup/bug1049291-2.1 |
Merge into: | lp:percona-xtrabackup/2.1 |
Diff against target: |
183 lines (+111/-9) 3 files modified
innobackupex.pl (+47/-9) test/t/bug1049291.sh (+23/-0) test/t/bug382742.sh (+41/-0) |
To merge this branch: | bzr merge lp:~akopytov/percona-xtrabackup/bug1049291-2.1 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexey Kopytov (community) | Approve | ||
Review via email: mp+195754@code.launchpad.net |
Description of the change
Bug #1049291: innobackupex --copy-back fails with an empty
The problem was that innobackupex unconditionally required
innodb-
when the value of that variable does not represent a valid path (it may
be empty), or point to root directory ("/") which naturally cannot be
empty.
Solutions:
- do not perform any checks for an empty innodb-
- assume an empty innodb-
datadir to replicate InnoDB behavior
- do not require innodb-
existing files in that directory. The non-empty requirement for the
data directory makes sense, it was implemented to fix bug
#737569. Requiring other directories to be empty is redundant, it is
sufficient to just refuse to overwrite any files.
The above changes, together with some previous bugfixes, automatically
fix bug #382742. So this patch adds a test case for that bug.
http://