Code review comment for lp:~akopytov/percona-server/bug878404-5.5
Revision history for this message
| Alexey Kopytov (akopytov) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
Yes, the return value of get_index_dynamic() must be signed because it returns -1 for a non-existing element. So the effective limit for dynamic array is LONG_MAX elements *if* get_index_dynamic() is used. I didn't want to change the interface to make the patch less intrusive. And it is enough for our purposes because:
- the value used to initialize it in sort.c is signed anyway
- get_index_dynamic() is not used in sort.c