Merge ~akbarkz/canonical-identity-provider:task/WD-8700-remove_cookie_message into canonical-identity-provider:master

Proposed by Akbar Abdrakhmanov
Status: Merged
Approved by: John Paraskevopoulos
Approved revision: 4d341010f72cddc48a3042b64675372e2ac7956f
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~akbarkz/canonical-identity-provider:task/WD-8700-remove_cookie_message
Merge into: canonical-identity-provider:master
Diff against target: 26 lines (+0/-4)
2 files modified
src/webui/templates/vanilla/_footer.html (+0/-1)
src/webui/templates/vanilla/base.html (+0/-3)
Reviewer Review Type Date Requested Status
John Paraskevopoulos Approve
Maximiliano Bertacchini Approve
Review via email: mp+460483@code.launchpad.net

Commit message

We have removed all tracking from the login.ubuntu.com and therefore only recording essential cookies which do not need consent.

Description of the change

The cookie message that opens when a user opens Ubuntu One UI is not needed anymore and is removed. Also an item "Manage your tracking settings" in the footer is removed.

To post a comment you must log in.
Revision history for this message
Maximiliano Bertacchini (maxiberta) wrote :

LGTM. Would you please clarify what's the rationale for this? I've tracked this to tickets WD-8700 and its parent WD-8699 but they lack a meaningful description. Thanks!

Revision history for this message
Akbar Abdrakhmanov (akbarkz) wrote :

> LGTM. Would you please clarify what's the rationale for this? I've tracked
> this to tickets WD-8700 and its parent WD-8699 but they lack a meaningful
> description. Thanks!

We have removed all tracking from the login.ubuntu.com and therefore only recording essential cookies which do not need consent.

Revision history for this message
Anton Kazakov (antonpkazakov) wrote :

The link will perhaps expire at some point, but so far this is the confirmation that we can do that: https://gdpr.eu/cookies/

> To comply with the regulations governing cookies under the GDPR and the ePrivacy Directive you must:
> - Receive users’ consent before you use any cookies **except** strictly necessary cookies.

Revision history for this message
Maximiliano Bertacchini (maxiberta) wrote :

+1 LGTM, thanks.

review: Approve
Revision history for this message
John Paraskevopoulos (quantifics) wrote :

lgtm thanks (was waiting for the rationale on this. Maybe it would be worth adding the "We have removed all tracking from the login.ubuntu.com and therefore only recording essential cookies which do not need consent." part on the commit message for future git log readers

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/webui/templates/vanilla/_footer.html b/src/webui/templates/vanilla/_footer.html
2index 6245dea..f13a298 100644
3--- a/src/webui/templates/vanilla/_footer.html
4+++ b/src/webui/templates/vanilla/_footer.html
5@@ -15,7 +15,6 @@ GNU Affero General Public License version 3 (see the file LICENSE).
6 <li class="p-inline-list__item"><a href="{{ 'privacy_policy'|static_url }}">{% trans "Canonical privacy notice" %}</a></li>
7 <li class="p-inline-list__item"><a href="{{ 'privacy_notice'|static_url }}">{% trans "SSO privacy notice" %}</a></li>
8 <li class="p-inline-list__item"><a href="{{ 'support_form'|static_url }}">{% trans "Support" %}</a></li>
9- <li class="p-inline-list__item"><a href="" class="js-revoke-cookie-manager">{% trans "Manage your tracker settings" %}</a></li>
10 <li class="p-inline-list__item"><a href="{{ 'dp_bugs'|static_url }}">{% trans "Report a bug on this site" %}</a></li>
11 {% block language_footer %}
12 {% if not embedded %}
13diff --git a/src/webui/templates/vanilla/base.html b/src/webui/templates/vanilla/base.html
14index 380f937..7f8cd4d 100644
15--- a/src/webui/templates/vanilla/base.html
16+++ b/src/webui/templates/vanilla/base.html
17@@ -129,9 +129,6 @@ YUI().use('node', 'transition', function (Y) {
18 });
19 </script>
20
21-<link rel="stylesheet" type="text/css" media="screen" href="https://assets.ubuntu.com/v1/f3dee679-cookie-policy-v3.2.0.css">
22-<script type="text/javascript" src="https://assets.ubuntu.com/v1/b9fc480c-cookie-policy-v3.2.0.js"></script>
23-<script>cpNs.cookiePolicy();</script>
24 {% endblock %}
25
26 {% block test_js %}{% endblock %}

Subscribers

People subscribed via source and target branches