Merge lp:~ajs-newmexico/bellepoule/fedora into lp:bellepoule
Status: | Merged |
---|---|
Merged at revision: | 268 |
Proposed branch: | lp:~ajs-newmexico/bellepoule/fedora |
Merge into: | lp:bellepoule |
Diff against target: |
51 lines (+9/-3) 4 files modified
.bzrignore (+4/-0) Makefile (+1/-1) sources/main.cpp (+2/-0) sources/table.hpp (+2/-2) |
To merge this branch: | bzr merge lp:~ajs-newmexico/bellepoule/fedora |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
betonniere | Approve | ||
Review via email:
|
Description of the change
Four files were changed for this merger proposal
.bzrignore was added to the top directory. This was done to ignore the generated bin and obj directories and two files generated by the Eclipse IDE
Makefile was changed by adding table_superviso
sources/main.cpp was changed by adding a condional compilation preprocessor check around the definitions of swprintf and vswprintf. The changes check for the definition of __MINGW32__ because I believe that they are only necessary when using the MinGW build environment. If they are needed for any Windows build environment, then the test should be for G_OS_WIN32 instead.
sources/table.hpp was changed by removing the redundant Table:: in the declaration of CompareMatchNumber
With these changes, BellePoulle successfully builds and runs on Fedora 14 in the Eclipse IDE build environment.
Strictly speaking the addition of .bzrignore is not necessary, but it makes the use of Eclipse easier.
WARNING: Use revision 274: there were several revisions where I had inadvertently committed some working files. I am still learning the way that Bazaar does things.