Merge lp:~ajs-newmexico/bellepoule/fedora into lp:bellepoule

Proposed by ajs
Status: Merged
Merged at revision: 268
Proposed branch: lp:~ajs-newmexico/bellepoule/fedora
Merge into: lp:bellepoule
Diff against target: 51 lines (+9/-3)
4 files modified
.bzrignore (+4/-0)
Makefile (+1/-1)
sources/main.cpp (+2/-0)
sources/table.hpp (+2/-2)
To merge this branch: bzr merge lp:~ajs-newmexico/bellepoule/fedora
Reviewer Review Type Date Requested Status
betonniere Approve
Review via email: mp+60145@code.launchpad.net

Description of the change

Four files were changed for this merger proposal

  .bzrignore was added to the top directory. This was done to ignore the generated bin and obj directories and two files generated by the Eclipse IDE

  Makefile was changed by adding table_supervisor.cpp and table_set.cpp to the SRC make variable. This was need ed to complete the link process

  sources/main.cpp was changed by adding a condional compilation preprocessor check around the definitions of swprintf and vswprintf. The changes check for the definition of __MINGW32__ because I believe that they are only necessary when using the MinGW build environment. If they are needed for any Windows build environment, then the test should be for G_OS_WIN32 instead.

  sources/table.hpp was changed by removing the redundant Table:: in the declaration of CompareMatchNumber

With these changes, BellePoulle successfully builds and runs on Fedora 14 in the Eclipse IDE build environment.

Strictly speaking the addition of .bzrignore is not necessary, but it makes the use of Eclipse easier.

WARNING: Use revision 274: there were several revisions where I had inadvertently committed some working files. I am still learning the way that Bazaar does things.

To post a comment you must log in.
Revision history for this message
betonniere (betonniere) :
review: Approve
lp:~ajs-newmexico/bellepoule/fedora updated
275. By ajs-newmexico

Modify the Makefile to make it work better for RPM packaging

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file '.bzrignore'
2--- .bzrignore 1970-01-01 00:00:00 +0000
3+++ .bzrignore 2011-05-06 05:43:22 +0000
4@@ -0,0 +1,4 @@
5+bin
6+obj
7+.cproject
8+.project
9
10=== modified file 'Makefile'
11--- Makefile 2011-01-20 15:52:25 +0000
12+++ Makefile 2011-05-06 05:43:22 +0000
13@@ -16,7 +16,7 @@
14 OPTSDBG=$(OPTS) -g
15
16 # Fichiers source à compiler et à linker, ATTENTION à mettre à jour la liste à chaque nouvelle version
17-SRCS=attendees.cpp attribute.cpp canvas.cpp canvas_module.cpp checkin.cpp classification.cpp contest.cpp data.cpp filter.cpp general_classification.cpp glade.cpp main.cpp match.cpp module.cpp object.cpp player.cpp players_list.cpp pool_allocator.cpp pool.cpp pool_match_order.cpp pool_supervisor.cpp schedule.cpp score_collector.cpp score.cpp sensitivity_trigger.cpp splitting.cpp stage.cpp swapper.cpp table.cpp tournament.cpp
18+SRCS=attendees.cpp attribute.cpp canvas.cpp canvas_module.cpp checkin.cpp classification.cpp contest.cpp data.cpp filter.cpp general_classification.cpp glade.cpp main.cpp match.cpp module.cpp object.cpp player.cpp players_list.cpp pool_allocator.cpp pool.cpp pool_match_order.cpp pool_supervisor.cpp schedule.cpp score_collector.cpp score.cpp sensitivity_trigger.cpp splitting.cpp stage.cpp swapper.cpp table.cpp tournament.cpp table_supervisor.cpp table_set.cpp
19 OBJS=$(SRCS:.cpp=.o)
20
21 # Nom du fichier exécutable à générer dans $(DBGDIR) et $(RLSDIR)
22
23=== modified file 'sources/main.cpp'
24--- sources/main.cpp 2011-02-15 21:47:36 +0000
25+++ sources/main.cpp 2011-05-06 05:43:22 +0000
26@@ -22,8 +22,10 @@
27 #include <stdlib.h>
28 #include <string.h>
29
30+#ifdef __MINGW32__ // MinGW defines several print functions differently (check for G_OS_WIN32 instead?)
31 extern "C" int swprintf (wchar_t *, size_t, const wchar_t *, ...);
32 extern "C" int vswprintf(wchar_t *, const wchar_t *, va_list);
33+#endif // __MINGW32__
34
35 #ifdef WINDOWS_TEMPORARY_PATCH
36 #define WIN32_LEAN_AND_MEAN
37
38=== modified file 'sources/table.hpp'
39--- sources/table.hpp 2011-04-30 21:43:46 +0000
40+++ sources/table.hpp 2011-05-06 05:43:22 +0000
41@@ -80,8 +80,8 @@
42
43 ~Table ();
44
45- static gint Table::CompareMatchNumber (Match *a,
46- Match *b);
47+ static gint CompareMatchNumber (Match *a,
48+ Match *b);
49
50 void LoadMatch (xmlNode *xml_node,
51 Match *match);

Subscribers

People subscribed via source and target branches

to all changes: